Re: [PATCH] crec: Add option to specify codec ID

[Charles Keepax <ckeepax@opensource.wolfsonmicro.com>]

On Wed, Nov 16, 2016 at 01:07:55PM +0000, Richard Fitzgerald wrote:
> On Wed, 2016-11-16 at 18:35 +0530, Vinod Koul wrote:
> > On Wed, Nov 16, 2016 at 11:44:09AM +0000, Richard Fitzgerald wrote:
> > > This patch adds a -I command line option to set the codec ID,
> > > either from a defined set of string values or as a number.
> > 
> > Can you explain why you want to add this? The utility cant really record a
> > mp3 file!
> > 
> > 
> 
> You need to be able to pass a codec ID that the driver supports, and to
> indicate which codec you're trying to use. It's not useful to only be
> able to open the "PCM" codec. It doesn't really matter whether crec
> understands the content of the data, we're just pulling raw data, most
> likely for test/debug.
> 
> The wm_adsp driver on Wolfson/Cirrus codecs uses the new BESPOKE stream
> ID so we need a way to pass that. And we'd also need it for any drivers
> that had streams using other codec IDs.
> 

Is the objection here not that crec is wrapping the data with
a WAV file? Should we perhaps just expand this so that if you
request a different format it uses the raw data mode that it uses
when you let the output go to stdout.

Thanks,
Charles