All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: Oliver Neukum <oneukum@suse.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Bin Gao <bin.gao@linux.intel.com>,
	Felipe Balbi <felipe.balbi@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	USB <linux-usb@vger.kernel.org>
Subject: Re: [PATHCv10 1/2] usb: USB Type-C connector class
Date: Wed, 16 Nov 2016 16:43:48 +0200	[thread overview]
Message-ID: <20161116144348.GC30235@kuha.fi.intel.com> (raw)
In-Reply-To: <CAPTae5KsUQow-Doo+Wc=Efc3cZpzUzZfszLOMkAKiF0PXtPiSQ@mail.gmail.com>

On Wed, Nov 16, 2016 at 06:30:23AM -0800, Badhri Jagan Sridharan wrote:
> > IMHO the uevent is cheaper. User space cannot just poll without further
> > infrastructure. A task needs to run to poll. A uevent can be handled
> > through established infrastructure.
> 
> Thanks Oliver for stating this. This is exactly what I was facing.
> 
> > OK, I'll add KOBJ_CHANGE for those.
> >
> > So is it OK to everybody if I remove the KOBJ_CHANGE in
> > typec_connect()? We will see uevent KOBJ_ADD since the partner (or
> > cable) is added in any case. Badhri, Oliver?
> 
> Yes Heikki.. That's OK for me as well.
> Just to get my understanding right. You are planning to add
> KOBJ_CHANGE uevents when current_power_role or
> current_data_role changes and KOBJ_ADD when new port-partner
> or the cable is attached. Is that right ?

Yes, though I don't KOBJ_ADD separately with the partners and cables.
That uevent is sent when the device for them is registered, so it's
already there.


Br,

-- 
heikki

  reply	other threads:[~2016-11-16 14:48 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-19 11:16 [PATHCv10 0/2] USB Type-C Connector class Heikki Krogerus
2016-09-19 11:16 ` [PATHCv10 1/2] usb: USB Type-C connector class Heikki Krogerus
2016-11-14  9:51   ` Greg KH
2016-11-14 12:32     ` Heikki Krogerus
2016-11-14 14:11       ` Greg KH
2016-11-14 14:39         ` Heikki Krogerus
2016-11-14 15:08           ` Greg KH
2016-11-14 14:34       ` Guenter Roeck
2016-11-16  8:47         ` Oliver Neukum
2016-11-14 20:46       ` Guenter Roeck
2016-11-15  7:07         ` Greg KH
2016-11-15  9:25           ` Guenter Roeck
2016-11-16  0:19             ` Badhri Jagan Sridharan
2016-11-16  9:30               ` Heikki Krogerus
2016-11-16  9:39                 ` Oliver Neukum
2016-11-16  9:49                 ` Greg KH
2016-11-16 11:09                   ` Heikki Krogerus
2016-11-16 11:27                     ` Oliver Neukum
2016-11-16 14:30                       ` Badhri Jagan Sridharan
2016-11-16 14:43                         ` Heikki Krogerus [this message]
2016-11-16 15:20     ` Heikki Krogerus
2016-11-16 15:25       ` Badhri Jagan Sridharan
2016-11-16 15:31       ` Greg KH
2016-11-17  8:28         ` Heikki Krogerus
2016-09-19 11:16 ` [PATHCv10 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus
2016-11-10 21:36 ` [PATHCv10 0/2] USB Type-C Connector class Guenter Roeck
2016-11-11 11:04   ` Heikki Krogerus
2016-11-14  7:46     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161116144348.GC30235@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=badhri@google.com \
    --cc=bin.gao@linux.intel.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.