All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
	marc.zyngier@arm.com, pbonzini@redhat.com,
	shannon.zhao@linaro.org
Subject: Re: [kvm-unit-tests PATCH] arm/arm64: introduce is_aarch32
Date: Wed, 16 Nov 2016 17:45:44 +0000	[thread overview]
Message-ID: <20161116174544.GE11228@leverpostej> (raw)
In-Reply-To: <1479307116-6355-1-git-send-email-drjones@redhat.com>

On Wed, Nov 16, 2016 at 03:38:36PM +0100, Andrew Jones wrote:
> ARMv7-A isn't exactly the same as ARMv8-A32 (AArch32). This
> function allows unit tests to make the distinction.
> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> 
> ---
> I'm actually unsure if there's a feature bit or not that I could
> probe instead. It'd be nice if somebody can confirm. Thanks, drew

> +/*
> + * ARMv7-A isn't exactly the same as ARMv8-A32 (AArch32). This
> + * function allows unit tests to make the distinction.
> + */

What do you want this for, specifically?

Since the CPUID registers were introduced, the architecture goes to
great lengths to not expose a version, and trying to guess from software
is a losing battle.

So I don't think we should try to distinguish ARMv8-A AArch32 from
ARMv7-A. We should test individual features, or if that's not possible,
group them in the same bucket.

Thanks,
Mark.

  parent reply	other threads:[~2016-11-16 17:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16 14:38 [kvm-unit-tests PATCH] arm/arm64: introduce is_aarch32 Andrew Jones
2016-11-16 17:42 ` Andre Przywara
2016-11-17 16:33   ` Andrew Jones
2016-11-16 17:45 ` Mark Rutland [this message]
2016-11-17 16:45   ` Andrew Jones
2016-11-17 17:47     ` Mark Rutland
2016-11-18 10:57       ` Andrew Jones
2016-11-16 17:46 ` Marc Zyngier
2016-11-16 22:02   ` Christopher Covington
2016-11-17  6:45     ` Wei Huang
2016-11-17 16:59     ` Andrew Jones
2016-11-18 15:06       ` Christopher Covington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161116174544.GE11228@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=marc.zyngier@arm.com \
    --cc=pbonzini@redhat.com \
    --cc=shannon.zhao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.