Re: [PATCH v4 00/10]remoteproc: qcom: Add support to hexagon q6v56 in qcom hexagon rproc driver

[Stephen Boyd <sboyd@codeaurora.org>]

On 11/16, Avaneesh Kumar Dwivedi wrote:
> This is patchset v4 having modifications as per comment on patchset v3.
> Major changes w.r.t. patchset v3 are as below.
> 	1- clean up of resource struct initialization.
> 	2- breaking up all changes into more number of logical patches.
> 	3- handling of clock through array of clock pointers.
> 	4- single place handling of proxy and active regulators.
> 	5- Addressing Other comments on last patches.
> 	
> There were certain comments which could not be addressed 
> 	1- To program MSS_RESET via GCC reset controller
> 	Since MSS_RESET does not control any clock as are done by other BCR or block control
> 	registers, so it does not qualify to be controlled by GCC reset controller.
> 	This is moreover like any other register, which can be programmed by IOREMAP.

Sorry I don't understand this reasoning at all. If MSS_RESET
lives in GCC, then it should be exposed as a reset through the
linux kernel reset APIs. It doesn't matter if that reset controls
or doesn't control a clock in the hardware implementation.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project