From: Eduardo Valentin <edubezval@gmail.com>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-pm@vger.kernel.org, rui.zhang@intel.com,
javi.merino@arm.com, orjan.eide@arm.com
Subject: Re: [PATCH 3/4] devfreq_cooling: let the driver supply the dynamic power every time we need it
Date: Wed, 16 Nov 2016 19:13:58 -0800 [thread overview]
Message-ID: <20161117031357.GA4852@localhost.localdomain> (raw)
In-Reply-To: <20160915144425.5443-4-lukasz.luba@arm.com>
On Thu, Sep 15, 2016 at 03:44:24PM +0100, Lukasz Luba wrote:
> The devfreq cooling implementation uses precalculated power table for caching
> power values for each device state. The power table is used everytime the
> thermal subsystem asks for the dynamic power, power2state, etc. There is no
> mechanism to provide the data in real-time from drivers' function registered as
> 'get_dynamic_power'. The power value can change in runtime, so the driver should
> choose one of the options (during the registration) what the thermal framework
> should do:
> o Use pre-calculated power table
> o Use direct call to driver's 'get_dynamic_power' and 'power2state'
> registered functions
>
> With this patch, the driver can choose if the precalculated power table should
> be used or a direct call to registered functions 'get_dynamic_power' and
> 'power2state', to get more accurate values.
I see this change is doing several minor changes. Can it be split into
smaller patches?
- add feature flags. This change is not so clear if this is the best
approach either, as it is a feature flag of a single feature.
- several changes in function signature, removing voltage parameter.
next prev parent reply other threads:[~2016-11-17 3:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 14:44 [PATCH 0/4] devfreq_cooling: let the driver supply the dynamic power every time we need it Lukasz Luba
2016-09-15 14:44 ` [PATCH 1/4] devfreq_cooling: make the structs devfreq_cooling_xxx visible for all Lukasz Luba
2016-09-15 14:44 ` [PATCH 2/4] devfreq_cooling: pass a pointer to devfreq in the power model callbacks Lukasz Luba
2016-09-15 14:44 ` [PATCH 3/4] devfreq_cooling: let the driver supply the dynamic power every time we need it Lukasz Luba
2016-11-17 3:13 ` Eduardo Valentin [this message]
2016-11-17 15:26 ` Lukasz Luba
2016-09-15 14:44 ` [PATCH 4/4] devfreq_cooling: fix unnecessary check of unsigned long value Lukasz Luba
2016-09-27 14:43 ` [PATCH 0/4] devfreq_cooling: let the driver supply the dynamic power every time we need it Lukasz Luba
2016-09-28 1:26 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117031357.GA4852@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=javi.merino@arm.com \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=orjan.eide@arm.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.