From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7E9K-0001Yd-1m for qemu-devel@nongnu.org; Wed, 16 Nov 2016 23:18:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7E9I-0002Uf-Os for qemu-devel@nongnu.org; Wed, 16 Nov 2016 23:18:10 -0500 Date: Thu, 17 Nov 2016 15:16:02 +1100 From: David Gibson Message-ID: <20161117041602.GI18808@umbus.fritz.box> References: <1479326850-8369-1-git-send-email-joserz@linux.vnet.ibm.com> <1479326850-8369-4-git-send-email-joserz@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="K1SnTjlYS/YgcDEx" Content-Disposition: inline In-Reply-To: <1479326850-8369-4-git-send-email-joserz@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 3/4] target-ppc: Implement bcdcpsgn. instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jose Ricardo Ziviani Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com --K1SnTjlYS/YgcDEx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 16, 2016 at 06:07:29PM -0200, Jose Ricardo Ziviani wrote: > bcdcpsgn.: Decimal copy sign. Given two registers vra and vrb, it > copies the vra value with vrb sign to the result register vrt. >=20 > Signed-off-by: Jose Ricardo Ziviani > --- > target-ppc/helper.h | 1 + > target-ppc/int_helper.c | 30 ++++++++++++++++++++++++++++++ > target-ppc/translate/vmx-impl.inc.c | 3 +++ > target-ppc/translate/vmx-ops.inc.c | 2 +- > 4 files changed, 35 insertions(+), 1 deletion(-) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index 503f257..dada48e 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -384,6 +384,7 @@ DEF_HELPER_3(bcdcfz, i32, avr, avr, i32) > DEF_HELPER_3(bcdctz, i32, avr, avr, i32) > DEF_HELPER_3(bcdcfsq, i32, avr, avr, i32) > DEF_HELPER_3(bcdctsq, i32, avr, avr, i32) > +DEF_HELPER_4(bcdcpsgn, i32, avr, avr, avr, i32) > =20 > DEF_HELPER_2(xsadddp, void, env, i32) > DEF_HELPER_2(xssubdp, void, env, i32) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index 1025438..a215bfe 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -2961,6 +2961,36 @@ uint32_t helper_bcdctsq(ppc_avr_t *r, ppc_avr_t *b= , uint32_t ps) > return cr; > } > =20 > +uint32_t helper_bcdcpsgn(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b, uint3= 2_t ps) > +{ > + int i; > + int cr =3D 0; > + int sgna =3D bcd_get_sgn(a); > + int sgnb =3D bcd_get_sgn(b); > + int invalid =3D (sgna =3D=3D 0) || (sgnb =3D=3D 0); > + ppc_avr_t ret =3D { .u64 =3D { 0, 0 } }; > + > + for (i =3D 1; i < 32; i++) { > + bcd_put_digit(&ret, bcd_get_digit(a, i, &invalid), i); > + bcd_get_digit(b, i, &invalid); This is a lot of bit fiddling to accomplish what you could pretty much do just by copying the entire register. Checking for invalid input makes it a bit more complex than that, of course, but you still don't need to assemble every digit separately in the target. > + > + if (unlikely(invalid)) { > + break; > + } > + } > + bcd_put_digit(&ret, bcd_get_digit(b, 0, &invalid), 0); This won't work. bcd_get_digit() will set invalid if digit 0 is an invalid *digit*. But some valid sign indicators are not valid digits, so this will erroneously set invalid in those cases. > + > + cr =3D bcd_cmp_zero(a); > + > + if (unlikely(invalid)) { > + cr =3D 1 << CRF_SO; > + } > + > + *r =3D ret; > + > + return cr; > +} > + > void helper_vsbox(ppc_avr_t *r, ppc_avr_t *a) > { > int i; > diff --git a/target-ppc/translate/vmx-impl.inc.c b/target-ppc/translate/v= mx-impl.inc.c > index 1579b58..c14b666 100644 > --- a/target-ppc/translate/vmx-impl.inc.c > +++ b/target-ppc/translate/vmx-impl.inc.c > @@ -991,6 +991,7 @@ GEN_BCD2(bcdcfz) > GEN_BCD2(bcdctz) > GEN_BCD2(bcdcfsq) > GEN_BCD2(bcdctsq) > +GEN_BCD(bcdcpsgn); > =20 > static void gen_xpnd04_1(DisasContext *ctx) > { > @@ -1056,6 +1057,8 @@ GEN_VXFORM_DUAL(vsubuhm, PPC_ALTIVEC, PPC_NONE, \ > bcdsub, PPC_NONE, PPC2_ALTIVEC_207) > GEN_VXFORM_DUAL(vsubuhs, PPC_ALTIVEC, PPC_NONE, \ > bcdsub, PPC_NONE, PPC2_ALTIVEC_207) > +GEN_VXFORM_DUAL(vaddshs, PPC_ALTIVEC, PPC_NONE, \ > + bcdcpsgn, PPC_NONE, PPC2_ISA300) > =20 > static void gen_vsbox(DisasContext *ctx) > { > diff --git a/target-ppc/translate/vmx-ops.inc.c b/target-ppc/translate/vm= x-ops.inc.c > index f02b3be..70d7d2b 100644 > --- a/target-ppc/translate/vmx-ops.inc.c > +++ b/target-ppc/translate/vmx-ops.inc.c > @@ -131,7 +131,7 @@ GEN_VXFORM_DUAL(vaddubs, vmul10uq, 0, 8, PPC_ALTIVEC,= PPC_NONE), > GEN_VXFORM_DUAL(vadduhs, vmul10euq, 0, 9, PPC_ALTIVEC, PPC_NONE), > GEN_VXFORM(vadduws, 0, 10), > GEN_VXFORM(vaddsbs, 0, 12), > -GEN_VXFORM(vaddshs, 0, 13), > +GEN_VXFORM_DUAL(vaddshs, bcdcpsgn, 0, 13, PPC_ALTIVEC, PPC_NONE), > GEN_VXFORM(vaddsws, 0, 14), > GEN_VXFORM_DUAL(vsububs, bcdadd, 0, 24, PPC_ALTIVEC, PPC_NONE), > GEN_VXFORM_DUAL(vsubuhs, bcdsub, 0, 25, PPC_ALTIVEC, PPC_NONE), --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --K1SnTjlYS/YgcDEx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYLS8CAAoJEGw4ysog2bOSK18QALY6YeGSLd7XdoCrh3g0pHyl EQROBxSscnsloh8GKJzEqko9+i0J0JlxVF8oXN7ysp0nzeNby6dpN5tgycqYbI+B w6OOTfZgXWK4t25u8Vv8gUu5eExH5JjSWaHUdBLU6SYaOsVDmV/CI8hJxG349Ye/ jREptG7J1BsmqaxBEzBMTD/mo0sDNluP8UfG5ODBaIdMTIX5trB4aesosOotxjJj Zh/e2ujIBerABGn/zgB01GBd8ghKMYlvvQJPHeeZa69npbLipyo5uHhVPjEom2Kd sHJ/74+fbkYOX6UkL/7428YShVNROOXH6ifn2/pEubiiJJUhrYzGhAVhyc3Z1J/a YHEy/4JRU8nawRlfogVQ7x8p5P28bLijVO2R3380sCixQwH6QZQbz6sbjF3hyzuO ch8Z1jtQcACJhXk6VPt1KSVuKkqpSVUKK+lWPYKY9BW63NTWXAcNHlkB6QzaRmWY gW4NOGFaaKkeyxdKhVZxTrzy0vVgoxgl5rxQ+341iaH2pTaP6ZDHVDjaXJ4kKBXc ryKx2mOzO8ZdoasxzVo12Swkb7unXUUGneYNSa31UHb4jQMm2sofOQhR6Mo4vv8q t61ur3DCkORCkaeOukRi1uL4Hrp5g+Zz6GJyJhmHoVdhWPkbSQFkYUUO6O0HlZV5 +laY5N+lZo+9YVkapwtu =bkMg -----END PGP SIGNATURE----- --K1SnTjlYS/YgcDEx--