From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45966)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <groug@kaod.org>) id 1c7IiN-0008Eg-5U
	for qemu-devel@nongnu.org; Thu, 17 Nov 2016 04:10:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <groug@kaod.org>) id 1c7IiI-0003NH-6a
	for qemu-devel@nongnu.org; Thu, 17 Nov 2016 04:10:39 -0500
Received: from 2.mo53.mail-out.ovh.net ([178.33.254.39]:39949)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <groug@kaod.org>) id 1c7IiI-0003MR-0a
	for qemu-devel@nongnu.org; Thu, 17 Nov 2016 04:10:34 -0500
Received: from player158.ha.ovh.net (b7.ovh.net [213.186.33.57])
	by mo53.mail-out.ovh.net (Postfix) with ESMTP id 2D65F43EFD
	for <qemu-devel@nongnu.org>; Thu, 17 Nov 2016 10:10:31 +0100 (CET)
Date: Thu, 17 Nov 2016 10:10:26 +0100
From: Greg Kurz <groug@kaod.org>
Message-ID: <20161117101026.77534496@bahia>
In-Reply-To: <20161117080738.GB2058@lemon>
References: <147648037766.14770.15179642645810274907.stgit@bahia>
	<bea953b7-2f30-98b4-e488-dcbae6ae1e9e@redhat.com>
	<20161018151646.GI12728@redhat.com>
	<20161018153124.GB15199@redhat.com> <20161018175200.48a2d3cc@bahia>
	<20161020142520.GB2733@stefanha-x1.localdomain>
	<20161117080738.GB2058@lemon>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] trace: fix group name generation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>

On Thu, 17 Nov 2016 16:07:38 +0800
Fam Zheng <famz@redhat.com> wrote:

> On Thu, 10/20 15:25, Stefan Hajnoczi wrote:
> > > 
> > > I have two other patches ready to fix the current situation:
> > > - one using os.getcwd() to guess the build directory
> > > - one implementing --group as mentioned in my other mail
> > > 
> > > But the one that filters unwanted characters is a less intrusive
> > > workaround.  
> > 
> > If Dan's patches will eliminate the issue then we can take a workaround.
> > 
> > Any more comments about Greg's patch before I merge it?  
> 
> Should we include this in -rc1? I still see a build error today.
> 
> Fam
> 

Hi Fam,

My patch was partly superseded by this commit:

commit 630b210b9abbf362905a2096c22c5eb1d6224e77
Author: Stefan Weil <sw@weilnetz.de>
Date:   Thu Oct 13 20:29:30 2016 +0200

    Fix build for less common build directories names

which does:

-    return re.sub(r"/|-", "_", dirname)
+    return re.sub(r"[^A-Za-z0-9]", "_", dirname)

What is the build error you're hitting ?

--
Greg