From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH 1/3] net/mlx5: fix leak when starvation occurs Date: Thu, 17 Nov 2016 11:37:40 +0100 Message-ID: <20161117103740.GA4729@6wind.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, stable@dpdk.org To: Nelio Laranjeiro Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id D24345680 for ; Thu, 17 Nov 2016 11:37:52 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id t79so135791076wmt.0 for ; Thu, 17 Nov 2016 02:37:52 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 17, 2016 at 10:49:54AM +0100, Nelio Laranjeiro wrote: > The list of segments to free was wrongly manipulated ending by only freeing > the first segment instead of freeing all of them. The last one still > belongs to the NIC and thus should not be freed. > > Fixes: a1bdb71a32da ("net/mlx5: fix crash in Rx") > > CC: stable@dpdk.org > Reported-by: Liming Sun > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_rxtx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index beff580..9bd4d80 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -1312,10 +1312,10 @@ mlx5_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n) > } > while (pkt != seg) { > assert(pkt != (*rxq->elts)[idx]); > - seg = NEXT(pkt); > + rep = NEXT(pkt); > rte_mbuf_refcnt_set(pkt, 0); > __rte_mbuf_raw_free(pkt); > - pkt = seg; > + pkt = rep; > } > break; > } > -- > 2.1.4 Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND