From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH 2/3] net/mlx5: fix wrong htons Date: Thu, 17 Nov 2016 11:38:11 +0100 Message-ID: <20161117103811.GB4729@6wind.com> References: <92fae1c8490a9dfa782bbd62bac21076832d4cee.1479376117.git.nelio.laranjeiro@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, stable@dpdk.org To: Nelio Laranjeiro Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 7AEC95687 for ; Thu, 17 Nov 2016 11:38:19 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id g23so301745926wme.1 for ; Thu, 17 Nov 2016 02:38:19 -0800 (PST) Content-Disposition: inline In-Reply-To: <92fae1c8490a9dfa782bbd62bac21076832d4cee.1479376117.git.nelio.laranjeiro@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 17, 2016 at 10:49:55AM +0100, Nelio Laranjeiro wrote: > Completion queue entry data uses network endian, to access them we should use > ntoh*(). > > Fixes: c305090bbaf8 ("net/mlx5: replace countdown with threshold for Tx completions") > > CC: stable@dpdk.org > Reported-by: Liming Sun > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index 9bd4d80..04860bb 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -201,7 +201,7 @@ txq_complete(struct txq *txq) > } while (1); > if (unlikely(cqe == NULL)) > return; > - wqe = &(*txq->wqes)[htons(cqe->wqe_counter) & > + wqe = &(*txq->wqes)[ntohs(cqe->wqe_counter) & > ((1 << txq->wqe_n) - 1)].hdr; > elts_tail = wqe->ctrl[3]; > assert(elts_tail < (1 << txq->wqe_n)); > -- > 2.1.4 Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND