From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:53602 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933286AbcKQLGo (ORCPT ); Thu, 17 Nov 2016 06:06:44 -0500 Date: Thu, 17 Nov 2016 12:06:54 +0100 From: Greg KH To: Daniel Wagner Cc: trond.myklebust@primarydata.com, Anna.Schumaker@Netapp.com, chuck.lever@oracle.com, stable@vger.kernel.org, stable-commits@vger.kernel.org Subject: Re: Patch "xprtrdma: use complete() instead complete_all()" has been added to the 4.8-stable tree Message-ID: <20161117110654.GB20153@kroah.com> References: <1479366910165203@kroah.com> <092fc57d-c150-6614-3492-f67f101c91b2@bmw-carit.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <092fc57d-c150-6614-3492-f67f101c91b2@bmw-carit.de> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Nov 17, 2016 at 11:55:31AM +0100, Daniel Wagner wrote: > Hi Greg, > > On 11/17/2016 08:15 AM, gregkh@linuxfoundation.org wrote: > > From 5690a22d8612e1788b48b4ea53c59868589cd2db Mon Sep 17 00:00:00 2001 > > From: Daniel Wagner > > Date: Fri, 23 Sep 2016 10:41:57 +0200 > > Subject: xprtrdma: use complete() instead complete_all() > > > > From: Daniel Wagner > > > > commit 5690a22d8612e1788b48b4ea53c59868589cd2db upstream. > > > > There is only one waiter for the completion, therefore there > > is no need to use complete_all(). Let's make that clear by > > using complete() instead of complete_all(). > > > > The usage pattern of the completion is: > > > > waiter context waker context > > > > frwr_op_unmap_sync() > > reinit_completion() > > ib_post_send() > > wait_for_completion() > > > > frwr_wc_localinv_wake() > > complete() > > I don't think this needs to got into stable. The original code isn't broken. > This patch is a cleanup unless I miss something :) It is needed for the patch after this one in the series. thanks, greg k-h