All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] ehea: Add 64bit statistics
Date: Thu, 17 Nov 2016 13:43:21 +0000	[thread overview]
Message-ID: <20161117134321.GA5096@mwanda> (raw)

Hello Anton Blanchard,

The patch 239c562c94dc: "ehea: Add 64bit statistics" from Oct 14,
2011, leads to the following static checker warning:

	drivers/net/ethernet/ibm/ehea/ehea_main.c:3047 ehea_setup_single_port()
	warn: struct type mismatch 'rtnl_link_stats64 vs net_device_stats'

drivers/net/ethernet/ibm/ehea/ehea_main.c
  3041          INIT_WORK(&port->reset_task, ehea_reset_port);
  3042          INIT_DELAYED_WORK(&port->stats_work, ehea_update_stats);
  3043  
  3044          init_waitqueue_head(&port->swqe_avail_wq);
  3045          init_waitqueue_head(&port->restart_wq);
  3046  
  3047          memset(&port->stats, 0, sizeof(struct net_device_stats));
                                               ^^^^^^^^^^^^^^^^^^^^^^^

This should be sizeof(struct rtnl_link_stats64).  But it's harmless,
the memory starts out as zeroed.  I don't have a cross compiler set up
so I'm not going to send a patch.

  3048          ret = register_netdev(dev);
  3049          if (ret) {
  3050                  pr_err("register_netdev failed. ret=%d\n", ret);
  3051                  goto out_unreg_port;
  3052          }

regards,
dan carpenter

                 reply	other threads:[~2016-11-17 13:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161117134321.GA5096@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.