From: Davidlohr Bueso <dave@stgolabs.net>
To: Waiman Long <longman@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wake_q: rename WAKE_Q to DEFINE_WAKE_Q
Date: Thu, 17 Nov 2016 10:13:45 -0800 [thread overview]
Message-ID: <20161117181345.GC18522@linux-80c1.suse> (raw)
In-Reply-To: <1479401198-1765-1-git-send-email-longman@redhat.com>
On Thu, 17 Nov 2016, Waiman Long wrote:
>Currently the wake_q data structure is defined by the WAKE_Q() macro.
>This macro, however, looks like a function doing something as "wake" is
>a verb. Even checkpatch.pl was confused as it reported warnings like
>
> WARNING: Missing a blank line after declarations
> #548: FILE: kernel/futex.c:3665:
> + int ret;
> + WAKE_Q(wake_q);
>
>This patch renames the WAKE_Q() macro to DEFINE_WAKE_Q() which clarifies
>what the macro is doing and eliminates the checkpatch.pl warnings.
No objection from me. Ack.
next prev parent reply other threads:[~2016-11-17 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 16:46 [PATCH] wake_q: rename WAKE_Q to DEFINE_WAKE_Q Waiman Long
2016-11-17 18:13 ` Davidlohr Bueso [this message]
2016-11-21 10:34 ` [tip:locking/core] sched/wake_q: Rename " tip-bot for Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117181345.GC18522@linux-80c1.suse \
--to=dave@stgolabs.net \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.