From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) Date: Fri, 18 Nov 2016 09:59:25 +0100 Subject: [PATCH v3 06/13] ARM: dts: armada-375: Fixup sa-ram DT warning In-Reply-To: <20161117230830.31047-7-gregory.clement@free-electrons.com> References: <20161117230830.31047-1-gregory.clement@free-electrons.com> <20161117230830.31047-7-gregory.clement@free-electrons.com> Message-ID: <20161118095925.770496c3@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On Fri, 18 Nov 2016 00:08:23 +0100, Gregory CLEMENT wrote: > - crypto_sram0: sa-sram0 { > + /* The following unit addresses (for sa-sram) are composed of > + * the target value (bit [40-47]), attributes value (bits > + * [32-39], and the address value in the window memory: [0-31]. > + */ The "address value in the window memory" part doesn't make a lot of sense. Maybe: "The following unit addresses are composed of the window target ID (bits 40-47), the window target attributes (bits 32-39) and the offset inside the window." Also, the comment formatting is not compliant with the coding style, should be: /* * ... * ... */ But do we really want this comment above each node? Couldn't we instead add this explanation in the mvebu-mbus.txt DT binding? Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH v3 06/13] ARM: dts: armada-375: Fixup sa-ram DT warning Date: Fri, 18 Nov 2016 09:59:25 +0100 Message-ID: <20161118095925.770496c3@free-electrons.com> References: <20161117230830.31047-1-gregory.clement@free-electrons.com> <20161117230830.31047-7-gregory.clement@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20161117230830.31047-7-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Gregory CLEMENT Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hello, On Fri, 18 Nov 2016 00:08:23 +0100, Gregory CLEMENT wrote: > - crypto_sram0: sa-sram0 { > + /* The following unit addresses (for sa-sram) are composed of > + * the target value (bit [40-47]), attributes value (bits > + * [32-39], and the address value in the window memory: [0-31]. > + */ The "address value in the window memory" part doesn't make a lot of sense. Maybe: "The following unit addresses are composed of the window target ID (bits 40-47), the window target attributes (bits 32-39) and the offset inside the window." Also, the comment formatting is not compliant with the coding style, should be: /* * ... * ... */ But do we really want this comment above each node? Couldn't we instead add this explanation in the mvebu-mbus.txt DT binding? Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html