From: Jiri Olsa <jolsa@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Liang, Kan" <kan.liang@intel.com>,
Andi Kleen <andi@firstfloor.org>, Vince Weaver <vince@deater.net>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] perf/x86/uncore: Allow single pmu/box within events group
Date: Fri, 18 Nov 2016 13:33:25 +0100 [thread overview]
Message-ID: <20161118123325.GA15416@krava> (raw)
In-Reply-To: <20161118112850.GO3117@twins.programming.kicks-ass.net>
On Fri, Nov 18, 2016 at 12:28:50PM +0100, Peter Zijlstra wrote:
> On Fri, Nov 18, 2016 at 01:15:28AM +0100, Jiri Olsa wrote:
> > Current uncore_validate_group code expects all events within
> > the group to have same pmu.
> >
> > This leads to constraint code using wrong boxes which leads
> > in my case to touching uninitialized spinlocks, but could
> > be probably worse.. depends on type and box details.
> >
> > I get lockdep warning below for following perf stat:
> > # perf stat -vv -e '{uncore_cbox_0/config=0x0334/,uncore_qpi_0/event=1/}' -a sleep 1
>
> Hurm, we shouldn't be allowing that in the first place I think.
>
>
> Let me stare at the generic group code, the intent was to only allow
> software events to mix with hw events, nothing else.
yep, that's what's happening now.. but after the event_init callback
jirka
next prev parent reply other threads:[~2016-11-18 12:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 0:15 [PATCH] perf/x86/uncore: Allow single pmu/box within events group Jiri Olsa
2016-11-18 11:28 ` Peter Zijlstra
2016-11-18 12:33 ` Jiri Olsa [this message]
2016-11-18 12:53 ` Peter Zijlstra
2016-11-18 13:23 ` Jiri Olsa
2016-11-18 13:48 ` Jiri Olsa
2016-11-18 14:06 ` Peter Zijlstra
2016-11-18 14:30 ` Jiri Olsa
2016-11-18 14:45 ` Peter Zijlstra
2016-11-22 12:30 ` [tip:perf/urgent] perf/x86/intel/uncore: Allow only a single PMU/box within an " tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118123325.GA15416@krava \
--to=jolsa@redhat.com \
--cc=andi@firstfloor.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.