From: Johan Hovold <johan@kernel.org>
To: Rahul Krishnan <mrahul.krishnan@gmail.com>
Cc: rmfrfs@gmail.com, elder@kernel.org, johan@kernel.org,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2]: staging: Greybus: Remove unnecessary braces for single statement block
Date: Fri, 18 Nov 2016 15:15:40 +0100 [thread overview]
Message-ID: <20161118141540.GH10490@localhost> (raw)
In-Reply-To: <20161118133419.GA4346@rahul>
On Fri, Nov 18, 2016 at 07:04:20PM +0530, Rahul Krishnan wrote:
> This patch fixes the following checkpath.pl warning
> WARNING: braces {} are not necessary for single statement blocks
>
> Fixed indentation error, noted by Dan Carpenter
>
> Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>
> ---
> drivers/staging/greybus/sdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
> index f60b458..66b37ea 100644
> --- a/drivers/staging/greybus/sdio.c
> +++ b/drivers/staging/greybus/sdio.c
> @@ -192,7 +192,7 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
> }
>
> if (event & GB_SDIO_WP)
> - host->read_only = true;
> + host->read_only = true;
You need to redo your original patch. This one instead looks like a
follow-up to your first revision (which actually removed the braces).
>
> if (state_changed) {
> dev_info(mmc_dev(host->mmc), "card %s now event\n",
Thanks,
Johan
prev parent reply other threads:[~2016-11-18 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 13:34 [PATCHv2]: staging: Greybus: Remove unnecessary braces for single statement block Rahul Krishnan
2016-11-18 14:15 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118141540.GH10490@localhost \
--to=johan@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mrahul.krishnan@gmail.com \
--cc=rmfrfs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.