From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Do not log disabled planes in pipe config
Date: Fri, 18 Nov 2016 16:19:59 +0200 [thread overview]
Message-ID: <20161118141959.GL31595@intel.com> (raw)
In-Reply-To: <65742c60-a034-7ce3-1655-2ba3994d89dc@linux.intel.com>
On Fri, Nov 18, 2016 at 03:13:14PM +0100, Maarten Lankhorst wrote:
> Op 18-11-16 om 12:40 schreef Tvrtko Ursulin:
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >
> > It just says "plane X disabled" which does not seem very useful.
> >
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Could we remove plane dumping altogether? It's not safe to do so in the way done by this function, and we could add missing things in intel_plane_atomic_calc_changes.
Yeah, might make sense to dump that stuff only from some plane code. And
we should probably take a good look at Rob Clark's new state dumping stuff
for that, so that we'll get it in some decently standardized format.
I must admit that I didn't take a very good look at Rob's stuff, but
maybe he already added the dumps to some useful places, and all we'd
have to do is expand the dumps with our own derived plane state...
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-18 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 11:40 [PATCH] drm/i915: Do not log disabled planes in pipe config Tvrtko Ursulin
2016-11-18 13:22 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-11-18 14:13 ` [PATCH] " Maarten Lankhorst
2016-11-18 14:19 ` Ville Syrjälä [this message]
2016-11-21 10:50 ` Tvrtko Ursulin
2016-11-21 11:15 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118141959.GL31595@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.