From: Eric Biggers <ebiggers@google.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
kernel@kyup.com, bp@alien8.de, stable@vger.kernel.org
Subject: Re: [PATCH 2/4] ext4: fix in-superblock mount options processing
Date: Fri, 18 Nov 2016 12:27:33 -0800 [thread overview]
Message-ID: <20161118202733.GA100623@google.com> (raw)
In-Reply-To: <20161118183842.25682-2-tytso@mit.edu>
On Fri, Nov 18, 2016 at 01:38:40PM -0500, Theodore Ts'o wrote:
> Fix a large number of problems with how we handle mount options in the
> superblock. For one, if the string in the superblock is long enough
> that it is not null terminated, we could run off the end of the string
> and try to interpret superblocks fields as characters. It's unlikely
> this will cause a security problem, but it could result in an invalid
> parse. Also, parse_options is destructive to the string, so in some
> cases if there is a comma-separated string, it would be modified in
> the superblock. (Fortunately it only happens on file systems with a
> 1k block size.)
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Cc: stable@vger.kernel.org
Reviewed-by: Eric Biggers <ebiggers@google.com>
next prev parent reply other threads:[~2016-11-18 20:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 18:38 [PATCH 1/4] ext4: sanity check the block and cluster size at mount time Theodore Ts'o
2016-11-18 18:38 ` [PATCH 2/4] ext4: fix in-superblock mount options processing Theodore Ts'o
2016-11-18 20:27 ` Eric Biggers [this message]
2016-11-18 18:38 ` [PATCH 3/4] ext4: use more strict checks for inodes_per_block on mount Theodore Ts'o
2016-11-18 20:30 ` Eric Biggers
2016-11-18 21:56 ` Theodore Ts'o
2016-11-18 18:38 ` [PATCH 4/4] ext4: add sanity checking to count_overhead() Theodore Ts'o
2016-11-18 20:02 ` [PATCH 1/4] ext4: sanity check the block and cluster size at mount time Eric Biggers
2016-11-18 21:55 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118202733.GA100623@google.com \
--to=ebiggers@google.com \
--cc=bp@alien8.de \
--cc=kernel@kyup.com \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.