From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Eli Cooper <elicooper@gmx.com>,
"David S. Miller" <davem@davemloft.net>
Subject: [PATCH 4.4 05/37] ip6_tunnel: Clear IP6CB in ip6tunnel_xmit()
Date: Sat, 19 Nov 2016 10:20:21 +0100 [thread overview]
Message-ID: <20161119092010.299702612@linuxfoundation.org> (raw)
In-Reply-To: <20161119092010.016555184@linuxfoundation.org>
4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Eli Cooper <elicooper@gmx.com>
[ Upstream commit 23f4ffedb7d751c7e298732ba91ca75d224bc1a6 ]
skb->cb may contain data from previous layers. In the observed scenario,
the garbage data were misinterpreted as IP6CB(skb)->frag_max_size, so
that small packets sent through the tunnel are mistakenly fragmented.
This patch unconditionally clears the control buffer in ip6tunnel_xmit(),
which affects ip6_tunnel, ip6_udp_tunnel and ip6_gre. Currently none of
these tunnels set IP6CB(skb)->flags, otherwise it needs to be done earlier.
Cc: stable@vger.kernel.org
Signed-off-by: Eli Cooper <elicooper@gmx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
include/net/ip6_tunnel.h | 1 +
1 file changed, 1 insertion(+)
--- a/include/net/ip6_tunnel.h
+++ b/include/net/ip6_tunnel.h
@@ -86,6 +86,7 @@ static inline void ip6tunnel_xmit(struct
struct net_device_stats *stats = &dev->stats;
int pkt_len, err;
+ memset(skb->cb, 0, sizeof(struct inet6_skb_parm));
pkt_len = skb->len - skb_inner_network_offset(skb);
err = ip6_local_out(dev_net(skb_dst(skb)->dev), sk, skb);
next prev parent reply other threads:[~2016-11-19 9:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161119092048epcas3p1db29198af4c10269f85a6b2169f469d8@epcas3p1.samsung.com>
2016-11-19 9:20 ` [PATCH 4.4 00/37] 4.4.34-stable review Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 01/37] dctcp: avoid bogus doubling of cwnd after loss Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 02/37] net: clear sk_err_soft in sk_clone_lock() Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 04/37] bgmac: stop clearing DMA receive control register right after it is set Greg Kroah-Hartman
2016-11-19 9:20 ` Greg Kroah-Hartman [this message]
2016-11-19 9:20 ` [PATCH 4.4 07/37] dccp: do not send reset to already closed sockets Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 08/37] dccp: fix out of bound access in dccp_v4_err() Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 09/37] ipv6: dccp: fix out of bound access in dccp_v6_err() Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 10/37] ipv6: dccp: add missing bind_conflict to dccp_ipv6_mapped Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 11/37] sctp: assign assoc_id earlier in __sctp_connect Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 12/37] fib_trie: Correct /proc/net/route off by one error Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 14/37] net: __skb_flow_dissect() must cap its return value Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 15/37] ipv4: use new_gw for redirect neigh lookup Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 16/37] tcp: take care of truncations done by sk_filter() Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 17/37] tty: Prevent ldisc drivers from re-using stale tty fields Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 18/37] sparc: Dont leak context bits into thread->fault_address Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 19/37] sparc: serial: sunhv: fix a double lock bug Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 20/37] sparc64 mm: Fix base TSB sizing when hugetlb pages are used Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 21/37] sparc: Handle negative offsets in arch_jump_label_transform Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 22/37] sparc64: Handle extremely large kernel TSB range flushes sanely Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 23/37] sparc64: Fix illegal relative branches in hypervisor patched TLB code Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 24/37] sparc64: Fix instruction count in comment for __hypervisor_flush_tlb_pending Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 25/37] sparc64: Fix illegal relative branches in hypervisor patched TLB cross-call code Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 26/37] sparc64: Handle extremely large kernel TLB range flushes more gracefully Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 27/37] sparc64: Delete __ret_efault Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 28/37] sparc64: Prepare to move to more saner user copy exception handling Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 29/37] sparc64: Convert copy_in_user to accurate exception reporting Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 30/37] sparc64: Convert GENcopy_{from,to}_user " Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 31/37] sparc64: Convert U1copy_{from,to}_user " Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 32/37] sparc64: Convert NG4copy_{from,to}_user " Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 33/37] sparc64: Convert NGcopy_{from,to}_user " Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 34/37] sparc64: Convert NG2copy_{from,to}_user " Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 35/37] sparc64: Convert U3copy_{from,to}_user " Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 36/37] sparc64: Delete now unused user copy assembler helpers Greg Kroah-Hartman
2016-11-19 9:20 ` [PATCH 4.4 37/37] sparc64: Delete now unused user copy fixup functions Greg Kroah-Hartman
2016-11-19 16:20 ` [PATCH 4.4 00/37] 4.4.34-stable review Guenter Roeck
2016-11-21 16:32 ` Shuah Khan
2016-11-21 16:49 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161119092010.299702612@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=elicooper@gmx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.