From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Date: Sat, 19 Nov 2016 11:53:01 +0000 Subject: Re: [PATCH v3 0/2] Ajust lockdep static allocations for sparc Message-Id: <20161119115301.GT3568@worktop.programming.kicks-ass.net> List-Id: References: <1475004808-91920-1-git-send-email-babu.moger@oracle.com> <20161118.143407.750907377181864816.davem@davemloft.net> In-Reply-To: <20161118.143407.750907377181864816.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller Cc: babu.moger@oracle.com, mingo@redhat.com, akpm@linux-foundation.org, keescook@chromium.org, dan.j.williams@intel.com, aryabinin@virtuozzo.com, tj@kernel.org, sam@ravnborg.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org On Fri, Nov 18, 2016 at 02:34:07PM -0500, David Miller wrote: > From: Babu Moger > Date: Tue, 27 Sep 2016 12:33:26 -0700 > > > These patches limit the static allocations for lockdep data structures > > used for debugging locking correctness. For sparc, all the kernel's code, > > data, and bss, must have locked translations in the TLB so that we don't > > get TLB misses on kernel code and data. Current sparc chips have 8 TLB > > entries available that may be locked down, and with a 4mb page size, > > this gives a maximum of 32MB. With PROVE_LOCKING we could go over this > > limit and cause system boot-up problems. These patches limit the static > > allocations so that everything fits in current required size limit. > > > > patch 1 : Adds new config parameter CONFIG_PROVE_LOCKING_SMALL > > Patch 2 : Adjusts the sizes based on the new config parameter > > > > v2-> v3: > > Some more comments from Sam Ravnborg and Peter Zijlstra. > > Defined PROVE_LOCKING_SMALL as invisible and moved the selection to > > arch/sparc/Kconfig. > > > > v1-> v2: > > As suggested by Peter Zijlstra, keeping the default as is. > > Introduced new config variable CONFIG_PROVE_LOCKING_SMALL > > to handle sparc specific case. > > > > v0: > > Initial revision. > > Series applied, thanks. Heh, I was only waiting for an ACK from you, but this works too :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753099AbcKSLxT (ORCPT ); Sat, 19 Nov 2016 06:53:19 -0500 Received: from merlin.infradead.org ([205.233.59.134]:47626 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752675AbcKSLxS (ORCPT ); Sat, 19 Nov 2016 06:53:18 -0500 Date: Sat, 19 Nov 2016 12:53:01 +0100 From: Peter Zijlstra To: David Miller Cc: babu.moger@oracle.com, mingo@redhat.com, akpm@linux-foundation.org, keescook@chromium.org, dan.j.williams@intel.com, aryabinin@virtuozzo.com, tj@kernel.org, sam@ravnborg.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3 0/2] Ajust lockdep static allocations for sparc Message-ID: <20161119115301.GT3568@worktop.programming.kicks-ass.net> References: <1475004808-91920-1-git-send-email-babu.moger@oracle.com> <20161118.143407.750907377181864816.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161118.143407.750907377181864816.davem@davemloft.net> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2016 at 02:34:07PM -0500, David Miller wrote: > From: Babu Moger > Date: Tue, 27 Sep 2016 12:33:26 -0700 > > > These patches limit the static allocations for lockdep data structures > > used for debugging locking correctness. For sparc, all the kernel's code, > > data, and bss, must have locked translations in the TLB so that we don't > > get TLB misses on kernel code and data. Current sparc chips have 8 TLB > > entries available that may be locked down, and with a 4mb page size, > > this gives a maximum of 32MB. With PROVE_LOCKING we could go over this > > limit and cause system boot-up problems. These patches limit the static > > allocations so that everything fits in current required size limit. > > > > patch 1 : Adds new config parameter CONFIG_PROVE_LOCKING_SMALL > > Patch 2 : Adjusts the sizes based on the new config parameter > > > > v2-> v3: > > Some more comments from Sam Ravnborg and Peter Zijlstra. > > Defined PROVE_LOCKING_SMALL as invisible and moved the selection to > > arch/sparc/Kconfig. > > > > v1-> v2: > > As suggested by Peter Zijlstra, keeping the default as is. > > Introduced new config variable CONFIG_PROVE_LOCKING_SMALL > > to handle sparc specific case. > > > > v0: > > Initial revision. > > Series applied, thanks. Heh, I was only waiting for an ACK from you, but this works too :-)