From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Andrew Honig <ahonig@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: fix missed SRCU usage in kvm_lapic_set_vapic_addr
Date: Sat, 19 Nov 2016 20:31:22 +0100 [thread overview]
Message-ID: <20161119193121.GD26213@potion> (raw)
In-Reply-To: <1479394547-15249-2-git-send-email-pbonzini@redhat.com>
2016-11-17 15:55+0100, Paolo Bonzini:
> Reported by syzkaller:
>
> [ INFO: suspicious RCU usage. ]
> 4.9.0-rc4+ #47 Not tainted
> -------------------------------
> ./include/linux/kvm_host.h:536 suspicious rcu_dereference_check() usage!
>
> stack backtrace:
> CPU: 1 PID: 6679 Comm: syz-executor Not tainted 4.9.0-rc4+ #47
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
> ffff880039e2f6d0 ffffffff81c2e46b ffff88003e3a5b40 0000000000000000
> 0000000000000001 ffffffff83215600 ffff880039e2f700 ffffffff81334ea9
> ffffc9000730b000 0000000000000004 ffff88003c4f8420 ffff88003d3f8000
> Call Trace:
> [< inline >] __dump_stack lib/dump_stack.c:15
> [<ffffffff81c2e46b>] dump_stack+0xb3/0x118 lib/dump_stack.c:51
> [<ffffffff81334ea9>] lockdep_rcu_suspicious+0x139/0x180 kernel/locking/lockdep.c:4445
> [< inline >] __kvm_memslots include/linux/kvm_host.h:534
> [< inline >] kvm_memslots include/linux/kvm_host.h:541
> [<ffffffff8105d6ae>] kvm_gfn_to_hva_cache_init+0xa1e/0xce0 virt/kvm/kvm_main.c:1941
> [<ffffffff8112685d>] kvm_lapic_set_vapic_addr+0xed/0x140 arch/x86/kvm/lapic.c:2217
>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Fixes: fda4e2e85589191b123d31cdc21fd33ee70f50fd
> Cc: Andrew Honig <ahonig@google.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
Applied to kvm/master, thanks.
prev parent reply other threads:[~2016-11-19 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 14:55 [PATCH] KVM: x86: fix missed SRCU usage in kvm_lapic_set_vapic_addr Paolo Bonzini
2016-11-17 17:37 ` David Hildenbrand
2016-11-19 19:31 ` Radim Krčmář [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161119193121.GD26213@potion \
--to=rkrcmar@redhat.com \
--cc=ahonig@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.