All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] kvm-unit-tests: only enable for ARM on Cortex-A7 and A15
Date: Sun, 20 Nov 2016 14:50:06 +0100	[thread overview]
Message-ID: <20161120135006.19498-2-arnout@mind.be> (raw)
In-Reply-To: <20161120135006.19498-1-arnout@mind.be>

The library uses the hypervisor instruction HVC, which is only
available on ARMv7-A with Hypervisor extensions. According to [1],
this is limited to Cortex-A7 and A15.

In addition the build unconditionally passes -marm so it also needs
ARM instructions to be available, but that is already implied by
the CPU selection.

Implicitly fixes
http://autobuild.buildroot.net/results/53d109fd9055fd20387bb857aced5f89cf3086fd
though it is still not clear why ld doesn't accept the -Ttext=...
option there.

[1] https://en.wikipedia.org/wiki/Comparison_of_ARMv7-A_cores

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/kvm-unit-tests/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/kvm-unit-tests/Config.in b/package/kvm-unit-tests/Config.in
index f704a8e..a25495a 100644
--- a/package/kvm-unit-tests/Config.in
+++ b/package/kvm-unit-tests/Config.in
@@ -4,7 +4,8 @@ config BR2_PACKAGE_KVM_UNIT_TESTS
 	# on i386 and x86-64, __builtin_reachable is used, so we need
 	# gcc 4.5 at least. on i386, we use the target gcc, while on
 	# x86-64 we use the host gcc (see .mk file for details)
-	depends on BR2_arm || \
+	# On ARM, it uses virtualization extensions
+	depends on (BR2_arm && (BR2_cortex_a7 || BR2_cortex_a15)) || \
 		(BR2_i386 && BR2_TOOLCHAIN_GCC_AT_LEAST_4_5) || \
 		BR2_powerpc64 || \
 		BR2_powerpc64le || \
-- 
2.10.2

  reply	other threads:[~2016-11-20 13:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-20 13:50 [Buildroot] [PATCH 1/2] kvm-unit-tests: pass the --processor configure argument Arnout Vandecappelle
2016-11-20 13:50 ` Arnout Vandecappelle [this message]
2016-11-20 14:50   ` [Buildroot] [PATCH 2/2] kvm-unit-tests: only enable for ARM on Cortex-A7 and A15 Thomas Petazzoni
2016-11-20 14:49 ` [Buildroot] [PATCH 1/2] kvm-unit-tests: pass the --processor configure argument Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161120135006.19498-2-arnout@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.