Re: [PATCH 1/1] v4l: videodev2: Include linux/time.h for timeval and timespec structs

[Mauro Carvalho Chehab <mchehab@s-opensource.com>]

Em Thu, 27 Oct 2016 13:50:51 +0300
Sakari Ailus <sakari.ailus@linux.intel.com> escreveu:

> struct timeval and struct timespec are defined in linux/time.h. Explicitly
> include the header if __KERNEL__ is defined.

The patch below doesn't do what you're mentioned above. It unconditionally
include linux/time.h, and, for userspace, it will *also* include
sys/time.h...

I suspect that this would cause problems on userspace.

Btw, you didn't mention on your description what's the bug you're
trying to fix.

> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  include/uapi/linux/videodev2.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 4364ce6..bbab50c 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -61,6 +61,7 @@
>  #endif
>  #include <linux/compiler.h>
>  #include <linux/ioctl.h>
> +#include <linux/time.h>
>  #include <linux/types.h>
>  #include <linux/v4l2-common.h>
>  #include <linux/v4l2-controls.h>


Thanks,
Mauro