diff for duplicates of <20161121115751.GL32509@dell> diff --git a/a/1.txt b/N1/1.txt index 534a291..7b547a6 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -123,7 +123,7 @@ Use `git send-email` where --thread should be the default. > +module_param_named(iledstr, s_iledstr, int, 0644); > +MODULE_PARM_DESC(iledstr, "Initial LED String (when no plat data)"); > + -> +static int s_retries = 2; /* 1 = only one try */ +> +static int s_retries = 2; /* 1 == only one try */ > +module_param_named(retries, s_retries, int, 0644); > +MODULE_PARM_DESC(retries, "I2C retries attempted"); > + @@ -217,17 +217,17 @@ Use `git send-email` where --thread should be the default. > + brightness = 0; > + > + /* set brightness */ -> + if (lp->mode = PWM_BASED) +> + if (lp->mode == PWM_BASED) > + ; /* via pwm */ -> + else if (lp->mode = REGISTER_BASED) +> + else if (lp->mode == REGISTER_BASED) > + arcxcnn_set_brightness(lp, brightness); > + > + /* set power-on/off/save modes */ -> + if (bl->props.power = 0) +> + if (bl->props.power == 0) > + /* take out of standby */ > + arcxcnn_update_bit(lp, ARCXCNN_CMD, ARCXCNN_CMD_STDBY, 0); > + else -> + /* 1-3 = power save, 4 = off +> + /* 1-3 == power save, 4 = off > + * place in low-power standby mode > + */ > + arcxcnn_update_bit(lp, ARCXCNN_CMD, @@ -293,7 +293,7 @@ Use `git send-email` where --thread should be the default. > + > + if (ledstr != lp->pdata->led_str) { > + /* don't allow 0 for ledstr, use power to turn all off */ -> + if (ledstr = 0) +> + if (ledstr == 0) > + return 0; > + lp->pdata->led_str = ledstr & 0x3F; > + arcxcnn_update_bit(lp, ARCXCNN_LEDEN, @@ -308,9 +308,9 @@ Use `git send-email` where --thread should be the default. > + struct arcxcnn *lp = dev_get_drvdata(dev); > + char *strmode = NULL; > + -> + if (lp->mode = PWM_BASED) +> + if (lp->mode == PWM_BASED) > + strmode = "pwm based"; -> + else if (lp->mode = REGISTER_BASED) +> + else if (lp->mode == REGISTER_BASED) > + strmode = "register based"; > + > + return scnprintf(buf, PAGE_SIZE, "%s\n", strmode); @@ -362,32 +362,32 @@ Use `git send-email` where --thread should be the default. > + lp->pdata->initial_brightness = MAX_BRIGHTNESS; > + > + ret = of_property_read_u32(node, "arc,led-config-0", &prog_val); -> + if (ret = 0) { +> + if (ret == 0) { > + lp->pdata->led_config_0 = (u8)prog_val; > + lp->pdata->led_config_0_set = true; > + } > + ret = of_property_read_u32(node, "arc,led-config-1", &prog_val); -> + if (ret = 0) { +> + if (ret == 0) { > + lp->pdata->led_config_1 = (u8)prog_val; > + lp->pdata->led_config_1_set = true; > + } > + ret = of_property_read_u32(node, "arc,dim-freq", &prog_val); -> + if (ret = 0) { +> + if (ret == 0) { > + lp->pdata->dim_freq = (u8)prog_val; > + lp->pdata->dim_freq_set = true; > + } > + ret = of_property_read_u32(node, "arc,comp-config", &prog_val); -> + if (ret = 0) { +> + if (ret == 0) { > + lp->pdata->comp_config = (u8)prog_val; > + lp->pdata->comp_config_set = true; > + } > + ret = of_property_read_u32(node, "arc,filter-config", &prog_val); -> + if (ret = 0) { +> + if (ret == 0) { > + lp->pdata->filter_config = (u8)prog_val; > + lp->pdata->filter_config_set = true; > + } > + ret = of_property_read_u32(node, "arc,trim-config", &prog_val); -> + if (ret = 0) { +> + if (ret == 0) { > + lp->pdata->trim_config = (u8)prog_val; > + lp->pdata->trim_config_set = true; > + } @@ -672,5 +672,5 @@ Use `git send-email` where --thread should be the default. -- Lee Jones Linaro STMicroelectronics Landing Team Lead -Linaro.org │ Open source software for ARM SoCs +Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog diff --git a/a/content_digest b/N1/content_digest index 6ef5412..dc69928 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -135,7 +135,7 @@ "> +module_param_named(iledstr, s_iledstr, int, 0644);\n" "> +MODULE_PARM_DESC(iledstr, \"Initial LED String (when no plat data)\");\n" "> +\n" - "> +static int s_retries = 2; /* 1 = only one try */\n" + "> +static int s_retries = 2; /* 1 == only one try */\n" "> +module_param_named(retries, s_retries, int, 0644);\n" "> +MODULE_PARM_DESC(retries, \"I2C retries attempted\");\n" "> +\n" @@ -229,17 +229,17 @@ "> +\t\tbrightness = 0;\n" "> +\n" "> +\t/* set brightness */\n" - "> +\tif (lp->mode = PWM_BASED)\n" + "> +\tif (lp->mode == PWM_BASED)\n" "> +\t\t; /* via pwm */\n" - "> +\telse if (lp->mode = REGISTER_BASED)\n" + "> +\telse if (lp->mode == REGISTER_BASED)\n" "> +\t\tarcxcnn_set_brightness(lp, brightness);\n" "> +\n" "> +\t/* set power-on/off/save modes */\n" - "> +\tif (bl->props.power = 0)\n" + "> +\tif (bl->props.power == 0)\n" "> +\t\t/* take out of standby */\n" "> +\t\tarcxcnn_update_bit(lp, ARCXCNN_CMD, ARCXCNN_CMD_STDBY, 0);\n" "> +\telse\n" - "> +\t\t/* 1-3 = power save, 4 = off\n" + "> +\t\t/* 1-3 == power save, 4 = off\n" "> +\t\t * place in low-power standby mode\n" "> +\t\t */\n" "> +\t\tarcxcnn_update_bit(lp, ARCXCNN_CMD,\n" @@ -305,7 +305,7 @@ "> +\n" "> +\tif (ledstr != lp->pdata->led_str) {\n" "> +\t\t/* don't allow 0 for ledstr, use power to turn all off */\n" - "> +\t\tif (ledstr = 0)\n" + "> +\t\tif (ledstr == 0)\n" "> +\t\t\treturn 0;\n" "> +\t\tlp->pdata->led_str = ledstr & 0x3F;\n" "> +\t\tarcxcnn_update_bit(lp, ARCXCNN_LEDEN,\n" @@ -320,9 +320,9 @@ "> +\tstruct arcxcnn *lp = dev_get_drvdata(dev);\n" "> +\tchar *strmode = NULL;\n" "> +\n" - "> +\tif (lp->mode = PWM_BASED)\n" + "> +\tif (lp->mode == PWM_BASED)\n" "> +\t\tstrmode = \"pwm based\";\n" - "> +\telse if (lp->mode = REGISTER_BASED)\n" + "> +\telse if (lp->mode == REGISTER_BASED)\n" "> +\t\tstrmode = \"register based\";\n" "> +\n" "> +\treturn scnprintf(buf, PAGE_SIZE, \"%s\\n\", strmode);\n" @@ -374,32 +374,32 @@ "> +\t\tlp->pdata->initial_brightness = MAX_BRIGHTNESS;\n" "> +\n" "> +\tret = of_property_read_u32(node, \"arc,led-config-0\", &prog_val);\n" - "> +\tif (ret = 0) {\n" + "> +\tif (ret == 0) {\n" "> +\t\tlp->pdata->led_config_0 = (u8)prog_val;\n" "> +\t\tlp->pdata->led_config_0_set = true;\n" "> +\t}\n" "> +\tret = of_property_read_u32(node, \"arc,led-config-1\", &prog_val);\n" - "> +\tif (ret = 0) {\n" + "> +\tif (ret == 0) {\n" "> +\t\tlp->pdata->led_config_1 = (u8)prog_val;\n" "> +\t\tlp->pdata->led_config_1_set = true;\n" "> +\t}\n" "> +\tret = of_property_read_u32(node, \"arc,dim-freq\", &prog_val);\n" - "> +\tif (ret = 0) {\n" + "> +\tif (ret == 0) {\n" "> +\t\tlp->pdata->dim_freq = (u8)prog_val;\n" "> +\t\tlp->pdata->dim_freq_set = true;\n" "> +\t}\n" "> +\tret = of_property_read_u32(node, \"arc,comp-config\", &prog_val);\n" - "> +\tif (ret = 0) {\n" + "> +\tif (ret == 0) {\n" "> +\t\tlp->pdata->comp_config = (u8)prog_val;\n" "> +\t\tlp->pdata->comp_config_set = true;\n" "> +\t}\n" "> +\tret = of_property_read_u32(node, \"arc,filter-config\", &prog_val);\n" - "> +\tif (ret = 0) {\n" + "> +\tif (ret == 0) {\n" "> +\t\tlp->pdata->filter_config = (u8)prog_val;\n" "> +\t\tlp->pdata->filter_config_set = true;\n" "> +\t}\n" "> +\tret = of_property_read_u32(node, \"arc,trim-config\", &prog_val);\n" - "> +\tif (ret = 0) {\n" + "> +\tif (ret == 0) {\n" "> +\t\tlp->pdata->trim_config = (u8)prog_val;\n" "> +\t\tlp->pdata->trim_config_set = true;\n" "> +\t}\n" @@ -684,7 +684,7 @@ "-- \n" "Lee Jones\n" "Linaro STMicroelectronics Landing Team Lead\n" - "Linaro.org \303\242\342\200\235\342\200\232 Open source software for ARM SoCs\n" + "Linaro.org \342\224\202 Open source software for ARM SoCs\n" Follow Linaro: Facebook | Twitter | Blog -7f80fdec9ba413fc2e6438edaa67468cff516103f4d716089f2e694317718efd +10c5898d38045fb10e0626a6bac3a2d61fa83b014e39d427d8a35c74324e8f0d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.