From: "André Draszik" <git@andred.net>
To: yocto@yoctoproject.org
Subject: [meta-swupd][PATCH 2/2] swupd-client: don't unconditionally depend on bash
Date: Mon, 21 Nov 2016 16:29:04 +0000 [thread overview]
Message-ID: <20161121162904.20027-2-git@andred.net> (raw)
In-Reply-To: <20161121162904.20027-1-git@andred.net>
From: André Draszik <adraszik@tycoint.com>
The swupd client itself does not depend on bash anymore since
version 3.3.0. Any posix shell is fine. So let's move the
runtime dependency to the appropriate place.
If some layer's oe-swupd-helpers.bbappend does introduce
a bash dependency, it should just state that dependency
itself.
As the shell now be provided by bash or busybox, also add
an appropriate entry to SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS.
Signed-off-by: André Draszik <adraszik@tycoint.com>
---
conf/layer.conf | 1 +
recipes-core/swupd-client/oe-swupd-helpers.bb | 3 +--
recipes-core/swupd-client/swupd-client_2.87.bb | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/conf/layer.conf b/conf/layer.conf
index 2998949..50e7558 100644
--- a/conf/layer.conf
+++ b/conf/layer.conf
@@ -13,4 +13,5 @@ LAYERVERSION_meta-swupd = "1"
SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += "\
oe-swupd-helpers->bash \
+ oe-swupd-helpers->busybox \
"
diff --git a/recipes-core/swupd-client/oe-swupd-helpers.bb b/recipes-core/swupd-client/oe-swupd-helpers.bb
index 4690f21..9a5a8dd 100644
--- a/recipes-core/swupd-client/oe-swupd-helpers.bb
+++ b/recipes-core/swupd-client/oe-swupd-helpers.bb
@@ -35,5 +35,4 @@ do_install () {
done
}
-RDEPENDS_${PN} += "bash"
-FILES_${PN} += "${systemd_system_unitdir}"
\ No newline at end of file
+FILES_${PN} += "${systemd_system_unitdir}"
diff --git a/recipes-core/swupd-client/swupd-client_2.87.bb b/recipes-core/swupd-client/swupd-client_2.87.bb
index 96e7a10..09d09a4 100644
--- a/recipes-core/swupd-client/swupd-client_2.87.bb
+++ b/recipes-core/swupd-client/swupd-client_2.87.bb
@@ -24,7 +24,7 @@ SRC_URI[md5sum] = "5d272c62edb8a9c576005ac5e1182ea3"
SRC_URI[sha256sum] = "45df259a7dc2fed985ee9961e112120fc46670dd75476c3262fc6804b1c66fb8"
DEPENDS = "glib-2.0 curl openssl libarchive"
-RDEPENDS_${PN}_append_class-target = " oe-swupd-helpers bsdtar"
+RDEPENDS_${PN}_append_class-target = " oe-swupd-helpers bash bsdtar"
# We check /etc/os-release for the current OS version number
RRECOMMENDS_${PN}_class-target = "os-release"
--
2.10.2
next prev parent reply other threads:[~2016-11-21 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 16:29 [meta-swupd][PATCH 1/2] oe-swupd-helpers: convert scripts to posix shell André Draszik
2016-11-21 16:29 ` André Draszik [this message]
2016-12-01 14:06 ` [meta-swupd][PATCH 2/2] swupd-client: don't unconditionally depend on bash Patrick Ohly
2016-12-01 14:06 ` [meta-swupd][PATCH 1/2] oe-swupd-helpers: convert scripts to posix shell Patrick Ohly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121162904.20027-2-git@andred.net \
--to=git@andred.net \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.