All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	ravi.bangoria@linux.vnet.ibm.com, acme@redhat.com,
	peterz@infradead.org, mingo@redhat.com,
	alexander.shishkin@linux.intel.com
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.orgp
Subject: Re: perf TUI fails with "failed to process type: 64"
Date: Mon, 21 Nov 2016 17:28:18 +1100	[thread overview]
Message-ID: <20161121172818.161639c2@kryten> (raw)
In-Reply-To: <20161009121232.174915eb@kryten>

Hi,

I forgot about the set of issues below. Michael had a suggested powerpc
fix for 3, but it it would be nice to fix the perf bugs in 1 and 2.

Anton
--

> Updating to mainline as of last night, I started seeing the following
> error when running the perf report TUI:
> 
> 0x46068 [0x8]: failed to process type: 68
> 
> This event is just PERF_RECORD_FINISHED_ROUND:
> 
> 0x46068 [0x8]: event: 68
> .
> . ... raw event: size 8 bytes
> .  0000:  44 00 00 00 00 00 08 00
> D.......        
> 
> 0x46068 [0x8]: PERF_RECORD_FINISHED_ROUND
> 
> Which of course is not our error. It took me a while to find the real
> culprit:
> 
>  14c00-14c00 g exc_virt_0x4c00_system_call
> 
> A zero length symbol, which __symbol__inc_addr_samples() barfs on:
> 
>         if (addr < sym->start || addr >= sym->end) {
> ...
> 		return -ERANGE;
> 
> Seems like we have 3 bugs here:
> 
> 1. Output the real source of the error instead of
> PERF_RECORD_FINISHED_ROUND
> 
> 2. Don't exit the TUI if we find a sample on a zero length symbol
> 
> 3. Why do we have zero length symbols in the first place? Does the
> recent ppc64 exception clean up have something to do with it?
> 
> Anton

  parent reply	other threads:[~2016-11-21  6:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-09  1:12 perf TUI fails with "failed to process type: 64" Anton Blanchard
2016-10-10  5:02 ` Michael Ellerman
2016-10-10  5:59   ` Nicholas Piggin
2016-10-10 10:18   ` Anton Blanchard
2016-10-10 10:39     ` Michael Ellerman
2016-11-21  6:28 ` Anton Blanchard [this message]
2016-11-22  8:40   ` [PATCH] perf TUI: Don't throw error for zero length symbols Ravi Bangoria
2016-11-22  8:49     ` Ravi Bangoria
2016-11-22  8:56       ` Ravi Bangoria
2016-12-16 10:38     ` Ravi Bangoria
2016-12-16 20:27       ` Anton Blanchard
2016-12-19 18:15         ` Arnaldo Carvalho de Melo
2016-12-20 19:30     ` [tip:perf/urgent] perf annotate: " tip-bot for Ravi Bangoria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161121172818.161639c2@kryten \
    --to=anton@samba.org \
    --cc=acme@redhat.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.orgp \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.