Re: [PATCHSET 0/7] perf sched: Introduce timehist command, again (v2)

[Namhyung Kim <namhyung@kernel.org>]

Hi Jiri,

On Wed, Nov 16, 2016 at 04:34:28PM +0100, Jiri Olsa wrote:
> On Wed, Nov 16, 2016 at 03:06:26PM +0900, Namhyung Kim wrote:
> > Hello,
> > 
> > This patchset is a rebased version of David's sched timehist work [1].
> > I plan to improve perf sched command more and think that having
> > timehist command before the work looks good.  It seems David is busy
> > these days, so I'm retrying it by myself.
> > 
> >  * changes in v2)
> >   - change name 'b/n time' to 'wait time'  (Ingo)
> >   - show arrow between functions in the callchain  (Ingo)
> >   - fix a bug in calculating initial run time
> 
> you might want to add some column width cuts.. I've got this:

The task name column width is initially set to 20, and grow
dynamically when longer name + tid/pid is found.  Maybe I need to
change it to have the max width initially.. (in later patch).

> 
>            time    cpu  task name             wait time  sch delay   run time
>                         [tid/pid]                (msec)     (msec)     (msec)
> --------------- ------  --------------------  ---------  ---------  ---------
>   482381.387934 [0000]  perf[6870]                0.000      0.000      0.000 
>   482381.388838 [0002]  <idle>                    0.000      0.000      0.000 
>   482381.388845 [0002]  plugin-containe[25990/25970]      0.000      0.004      0.007 
>   482381.388897 [0003]  <idle>                            0.000      0.000      0.000 
>   482381.388919 [0002]  <idle>                            0.007      0.000      0.074 
>   482381.388925 [0003]  Timer[15210/15178]                0.000      0.002      0.027 
> 
> 
> 
> other than that:
> 
> Acked-by: Jiri Olsa <jolsa@redhat.com>

Thanks,
Namhyung