From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH 1/4] lib/scatterlist: Fix offset type in sg_alloc_table_from_pages Date: Tue, 22 Nov 2016 12:31:50 -0200 Message-ID: <20161122123150.5b3ccbae@vento.lan> References: <1478854220-3255-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1478854220-3255-2-git-send-email-tvrtko.ursulin@linux.intel.com> <20161114095548.GC32240@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from osg.samsung.com (ec2-52-27-115-49.us-west-2.compute.amazonaws.com [52.27.115.49]) by gabe.freedesktop.org (Postfix) with ESMTP id A77A16E50C for ; Tue, 22 Nov 2016 14:31:58 +0000 (UTC) In-Reply-To: <20161114095548.GC32240@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Tomasz Stanislawski , Pawel Osciak , Alexandre Bounine , Intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Kyungmin Park , Matt Porter , Marek Szyprowski , linux-media@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org RW0gTW9uLCAxNCBOb3YgMjAxNiAwOTo1NTo0OCArMDAwMApDaHJpcyBXaWxzb24gPGNocmlzQGNo cmlzLXdpbHNvbi5jby51az4gZXNjcmV2ZXU6Cgo+IE9uIEZyaSwgTm92IDExLCAyMDE2IGF0IDA4 OjUwOjE3QU0gKzAwMDAsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+ID4gRnJvbTogVHZydGtvIFVy c3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiA+IAo+ID4gU2NhdHRlcmxpc3QgZW50 cmllcyBoYXZlIGFuIHVuc2lnbmVkIGludCBmb3IgdGhlIG9mZnNldCBzbwo+ID4gY29ycmVjdCB0 aGUgc2dfYWxsb2NfdGFibGVfZnJvbV9wYWdlcyBmdW5jdGlvbiBhY2NvcmRpbmdseS4KPiA+IAo+ ID4gU2luY2UgdGhlc2UgYXJlIG9mZnNldHMgd2l0aGluZyBhIHBhZ2UsIHVuc2lnbmVkIGludCBp cwo+ID4gd2lkZSBlbm91Z2guCj4gPiAKPiA+IEFsc28gY29udmVydHMgY2FsbGVycyB3aGljaCB3 ZXJlIHVzaW5nIHVuc2lnbmVkIGxvbmcgbG9jYWxseQo+ID4gd2l0aCB0aGUgbG93ZXJfMzJfYml0 cyBhbm5vdGF0aW9uIHRvIG1ha2UgaXQgZXhwbGljaXRseQo+ID4gY2xlYXIgd2hhdCBpcyBoYXBw ZW5pbmcuCj4gPiAKPiA+IHYyOiBVc2Ugb2Zmc2V0X2luX3BhZ2UuIChDaHJpcyBXaWxzb24pCj4g PiAKPiA+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRl bC5jb20+Cj4gPiBDYzogTWFzYWhpcm8gWWFtYWRhIDx5YW1hZGEubWFzYWhpcm9Ac29jaW9uZXh0 LmNvbT4KPiA+IENjOiBQYXdlbCBPc2NpYWsgPHBhd2VsQG9zY2lhay5jb20+Cj4gPiBDYzogTWFy ZWsgU3p5cHJvd3NraSA8bS5zenlwcm93c2tpQHNhbXN1bmcuY29tPgo+ID4gQ2M6IEt5dW5nbWlu IFBhcmsgPGt5dW5nbWluLnBhcmtAc2Ftc3VuZy5jb20+Cj4gPiBDYzogVG9tYXN6IFN0YW5pc2xh d3NraSA8dC5zdGFuaXNsYXdzQHNhbXN1bmcuY29tPgo+ID4gQ2M6IE1hdHQgUG9ydGVyIDxtcG9y dGVyQGtlcm5lbC5jcmFzaGluZy5vcmc+Cj4gPiBDYzogQWxleGFuZHJlIEJvdW5pbmUgPGFsZXhh bmRyZS5ib3VuaW5lQGlkdC5jb20+Cj4gPiBDYzogbGludXgtbWVkaWFAdmdlci5rZXJuZWwub3Jn Cj4gPiBDYzogbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZwo+ID4gQWNrZWQtYnk6IE1hcmVr IFN6eXByb3dza2kgPG0uc3p5cHJvd3NraUBzYW1zdW5nLmNvbT4gKHYxKSAgCj4gCj4gSWYgdGhl cmUgd2VyZSBrZXJuZWxkb2MsIGl0IHdvdWxkIG5pY2VseSBleHBsYWluIHRoYXQgaGF2aW5nIGFu IG9mZnNldAo+IGxhcmdlciB0aGVuIGEgcGFnZSBpcyBzaWxseSB3aGVuIHBhc3NpbmcgaW4gYXJy YXkgb2YgcGFnZXMuCj4gCj4gQ2hhbmdlcyBlbHNld2hlcmUgbG9vayBvayAocGVyc29uYWxseSBJ J2QgYmUgaGFwcHkgd2l0aCBqdXN0Cj4gb2Zmc2V0X2luX3BhZ2UoKSwgNEdpQiBzdXBlcnBhZ2Vz IGFyZSBzb21lYm9keSBlbHNlJ3MgcHJvYmxlbSA6KQoKRm9yIHRoZSBtZWRpYSBjaGFuZ2VzLCB0 aGF0IGxvb2tlZCBPSy4gV2UgZG9uJ3QgaGF2ZSBhbnkgbmVlZHMKdG8gc3RyZWFtIDRHQiBpbWFn ZXMgbm93YWRheXMgOi0pCgpSZXZpZXdlZC1ieTogTWF1cm8gQ2FydmFsaG8gQ2hlaGFiIDxtY2hl aGFiQHMtb3BlbnNvdXJjZS5jb20+CiAKPiBSZXZpZXdlZC1ieTogQ2hyaXMgV2lsc29uIDxjaHJp c0BjaHJpcy13aWxzb24uY28udWs+Cj4gLUNocmlzCj4gCgoKVGhhbmtzLApNYXVybwpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:42972 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933135AbcKVOb7 (ORCPT ); Tue, 22 Nov 2016 09:31:59 -0500 Date: Tue, 22 Nov 2016 12:31:50 -0200 From: Mauro Carvalho Chehab To: Chris Wilson Cc: Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org, Tomasz Stanislawski , Pawel Osciak , linux-kernel@vger.kernel.org, Masahiro Yamada , Kyungmin Park , Matt Porter , linux-media@vger.kernel.org, Alexandre Bounine , Marek Szyprowski Subject: Re: [Intel-gfx] [PATCH 1/4] lib/scatterlist: Fix offset type in sg_alloc_table_from_pages Message-ID: <20161122123150.5b3ccbae@vento.lan> In-Reply-To: <20161114095548.GC32240@nuc-i3427.alporthouse.com> References: <1478854220-3255-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1478854220-3255-2-git-send-email-tvrtko.ursulin@linux.intel.com> <20161114095548.GC32240@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Mon, 14 Nov 2016 09:55:48 +0000 Chris Wilson escreveu: > On Fri, Nov 11, 2016 at 08:50:17AM +0000, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > Scatterlist entries have an unsigned int for the offset so > > correct the sg_alloc_table_from_pages function accordingly. > > > > Since these are offsets withing a page, unsigned int is > > wide enough. > > > > Also converts callers which were using unsigned long locally > > with the lower_32_bits annotation to make it explicitly > > clear what is happening. > > > > v2: Use offset_in_page. (Chris Wilson) > > > > Signed-off-by: Tvrtko Ursulin > > Cc: Masahiro Yamada > > Cc: Pawel Osciak > > Cc: Marek Szyprowski > > Cc: Kyungmin Park > > Cc: Tomasz Stanislawski > > Cc: Matt Porter > > Cc: Alexandre Bounine > > Cc: linux-media@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Acked-by: Marek Szyprowski (v1) > > If there were kerneldoc, it would nicely explain that having an offset > larger then a page is silly when passing in array of pages. > > Changes elsewhere look ok (personally I'd be happy with just > offset_in_page(), 4GiB superpages are somebody else's problem :) For the media changes, that looked OK. We don't have any needs to stream 4GB images nowadays :-) Reviewed-by: Mauro Carvalho Chehab > Reviewed-by: Chris Wilson > -Chris > Thanks, Mauro