From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46414)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1c9BDm-0004xw-Mt
	for qemu-devel@nongnu.org; Tue, 22 Nov 2016 08:34:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1c9BDh-0006Ff-Ql
	for qemu-devel@nongnu.org; Tue, 22 Nov 2016 08:34:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56460)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <ehabkost@redhat.com>) id 1c9BDh-0006Ez-Kc
	for qemu-devel@nongnu.org; Tue, 22 Nov 2016 08:34:45 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id A48BD804EE
	for <qemu-devel@nongnu.org>; Tue, 22 Nov 2016 13:34:44 +0000 (UTC)
Date: Tue, 22 Nov 2016 11:34:42 -0200
From: Eduardo Habkost <ehabkost@redhat.com>
Message-ID: <20161122133442.GC21830@thinpad.lan.raisama.net>
References: <1479777133-23567-1-git-send-email-ehabkost@redhat.com>
	<1479777133-23567-6-git-send-email-ehabkost@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1479777133-23567-6-git-send-email-ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [RFC 05/15] tests: Add rules to non-gtester qtest
 test cases
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Marcel Apfelbaum <marcel@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

On Mon, Nov 21, 2016 at 11:12:03PM -0200, Eduardo Habkost wrote:
[...]
> +define qtest-target =

This breaks on old GNU Make versions. Both patchew and travis-ci reported
similar errors:

  make: *** No rule to make target `check-simpleqtest-x86_64', needed by
  `check-simpleqtest'.  Stop.

Old make versions don't seem to like the "=" operator after "define VAR".
Fixed by:

diff --git a/tests/Makefile.include b/tests/Makefile.include
index 7016737..2799b16 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -808,7 +808,7 @@ SIMPLETEST_OPTIONS = $(if $(V),--verbose,--quiet)
 # $(check-simpleqtest-$(ARCH)-y) automatically includes
 #                                $(check-simpleqtest-generic-y)
 
-define qtest-target =
+define qtest-target
 
 check-simpleqtest-$(1)-y += $$(check-simpleqtest-generic-y)
 

-- 
Eduardo