From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. Date: Tue, 22 Nov 2016 18:50:17 +0200 Message-ID: <20161122165017.GC31595@intel.com> References: <20161122164106.31852-1-Liviu.Dudau@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E8096E342 for ; Tue, 22 Nov 2016 16:50:21 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161122164106.31852-1-Liviu.Dudau@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Liviu Dudau Cc: Jani Nikula , Daniel Vetter , Eric Engestrom , LKML , DRI devel List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBOb3YgMjIsIDIwMTYgYXQgMDQ6NDE6MDZQTSArMDAwMCwgTGl2aXUgRHVkYXUgd3Jv dGU6Cj4gZHJtX2dldF9mb3JtYXRfbmFtZSgpIGRlLXJlZmVyZW5jZXMgdGhlIGJ1ZiBwYXJhbWV0 ZXIgd2l0aG91dCBjaGVja2luZwo+IGlmIHRoZSBwb2ludGVyIHdhcyBub3QgTlVMTC4gR2l2ZW4g dGhhdCB0aGUgZnVuY3Rpb24gaXMgRVhQT1JULWVkLCBsZXRzCj4gc2FuaXRpc2UgdGhlIHBhcmFt ZXRlcnMgYmVmb3JlIHByb2NlZWRpbmcuCj4gCj4gRml4ZXM6IGIzYzExYWMyNjdkNDYxZDNkNSAo ImRybTogbW92ZSBhbGxvY2F0aW9uIG91dCBvZiBkcm1fZ2V0X2Zvcm1hdF9uYW1lKCkpCj4gQ2M6 IEVyaWMgRW5nZXN0cm9tIDxlcmljQGVuZ2VzdHJvbS5jaD4KPiBDYzogUm9iIENsYXJrIDxyb2Jk Y2xhcmtAZ21haWwuY29tPgo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29t Pgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IAo+IFNpZ25l ZC1vZmYtYnk6IExpdml1IER1ZGF1IDxMaXZpdS5EdWRhdUBhcm0uY29tPgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5jIHwgMyArKysKPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5z ZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5j IGIvZHJpdmVycy9ncHUvZHJtL2RybV9mb3VyY2MuYwo+IGluZGV4IDkwZDJjYzguLjBhM2ZmMGIg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mb3VyY2MuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fZm91cmNjLmMKPiBAQCAtODUsNiArODUsOSBAQCBFWFBPUlRfU1lNQk9M KGRybV9tb2RlX2xlZ2FjeV9mYl9mb3JtYXQpOwo+ICAgKi8KPiAgY29uc3QgY2hhciAqZHJtX2dl dF9mb3JtYXRfbmFtZSh1aW50MzJfdCBmb3JtYXQsIHN0cnVjdCBkcm1fZm9ybWF0X25hbWVfYnVm ICpidWYpCj4gIHsKPiArCWlmICghYnVmKQo+ICsJCXJldHVybiBOVUxMOwo+ICsKClNlZW1zIHJh dGhlciBwb2ludGxlc3MgdG8gbWUuIFdoeSB3b3VsZCB5b3UgZXZlciBwYXNzIE5VTEwgdG8gdGhp cyBndXk/Cgo+ICAJc25wcmludGYoYnVmLT5zdHIsIHNpemVvZihidWYtPnN0ciksCj4gIAkJICIl YyVjJWMlYyAlcy1lbmRpYW4gKDB4JTA4eCkiLAo+ICAJCSBwcmludGFibGVfY2hhcihmb3JtYXQg JiAweGZmKSwKPiAtLSAKPiAyLjEwLjIKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932933AbcKVQvm (ORCPT ); Tue, 22 Nov 2016 11:51:42 -0500 Received: from mga01.intel.com ([192.55.52.88]:58516 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932858AbcKVQvk (ORCPT ); Tue, 22 Nov 2016 11:51:40 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,533,1473145200"; d="scan'208";a="789548786" Date: Tue, 22 Nov 2016 18:50:17 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Liviu Dudau Cc: Eric Engestrom , Daniel Vetter , LKML , DRI devel , Jani Nikula Subject: Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. Message-ID: <20161122165017.GC31595@intel.com> References: <20161122164106.31852-1-Liviu.Dudau@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161122164106.31852-1-Liviu.Dudau@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 22, 2016 at 04:41:06PM +0000, Liviu Dudau wrote: > drm_get_format_name() de-references the buf parameter without checking > if the pointer was not NULL. Given that the function is EXPORT-ed, lets > sanitise the parameters before proceeding. > > Fixes: b3c11ac267d461d3d5 ("drm: move allocation out of drm_get_format_name()) > Cc: Eric Engestrom > Cc: Rob Clark > Cc: Jani Nikula > Cc: Daniel Vetter > > Signed-off-by: Liviu Dudau > --- > drivers/gpu/drm/drm_fourcc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c > index 90d2cc8..0a3ff0b 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -85,6 +85,9 @@ EXPORT_SYMBOL(drm_mode_legacy_fb_format); > */ > const char *drm_get_format_name(uint32_t format, struct drm_format_name_buf *buf) > { > + if (!buf) > + return NULL; > + Seems rather pointless to me. Why would you ever pass NULL to this guy? > snprintf(buf->str, sizeof(buf->str), > "%c%c%c%c %s-endian (0x%08x)", > printable_char(format & 0xff), > -- > 2.10.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC