Re: [PATCH] module.bbclass: allow to override location of Module.symvers

[Denys Dmytriyenko <denis@denix.org>]

On Mon, Nov 21, 2016 at 09:37:13AM +0000, André Draszik wrote:
> From: André Draszik <adraszik@tycoint.com>
> 
> Requiring all build systems for external kernel modules to
> place Module.symvers directly into ${B}/. is quite an
> artificial assumption/requirement. It doesn't have to end
> up there, but could easily end up somewhere below ${B}.
> 
> Allow to override the location below ${B}
> 
> Note that we still don't make use of multiple
> Module.symvers in case there are any generated by one
> single kernel module build, but this is no change in
> behaviour from before and could be added if there really
> is a demand for that.
> 
> Reported-by: Denys Dmytriyenko <denis@denix.org>
> Signed-off-by: André Draszik <adraszik@tycoint.com>

Looks good to me, thanks.
Acked-by: Denys Dmytriyenko <denys@ti.com>


> ---
>  meta/classes/module.bbclass | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)

[...]

> -	install -d -m0755 ${D}${includedir}/${BPN}
> -	cp -a --no-preserve=ownership ${B}/Module.symvers ${D}${includedir}/${BPN}
> -	# it doesn't actually seem to matter which path is specified here
> -	sed -e 's:${B}/::g' -i ${D}${includedir}/${BPN}/Module.symvers
> +	if [ ! -e "${B}/${MODULES_MODULE_SYMVERS_LOCATION}/Module.symvers" ] ; then
> +		bbwarn "Module.symvers not found in ${B}/${MODULES_MODULE_SYMVERS_LOCATION}"
> +		bbwarn "Please consider setting MODULES_MODULE_SYMVERS_LOCATION to a"
> +		bbwarn "directory below B to get correct inter-module dependencies"
> +	else
> +		install -Dm0644 "${B}/${MODULES_MODULE_SYMVERS_LOCATION}"/Module.symvers ${D}${includedir}/${BPN}/Module.symvers

BTW, is "-Dm0644" portable?


> +		# Module.symvers contains absolute path to the build directory.
> +		# While it doesn't actually seem to matter which path is specified,
> +		# clear them out to avoid confusion
> +		sed -e 's:${B}/::g' -i ${D}${includedir}/${BPN}/Module.symvers
> +	fi