Re: [PATCH 3/4] drm/radeon/atpx: check for ATIF dGPU wake for display events support

[Peter Wu <peter-VTkQYDcBqhK7DlmcbJSQ7g@public.gmane.org>]

On Wed, Sep 14, 2016 at 02:49:03PM -0400, Alex Deucher wrote:
> Some ATPX laptops implement special circuitry to generate
> display hotplug events via ACPI when the dGPU is powered off.
> Check if this is supported.
> 
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

This patch is missing a dgpu_req_power_for_displays, shouldn't you check
for the flag like you did in amdgpu?

Other than that, the patches look good to me.

Peter

> ---
>  drivers/gpu/drm/radeon/radeon_atpx_handler.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_atpx_handler.c b/drivers/gpu/drm/radeon/radeon_atpx_handler.c
> index 6de3428..a1321b2 100644
> --- a/drivers/gpu/drm/radeon/radeon_atpx_handler.c
> +++ b/drivers/gpu/drm/radeon/radeon_atpx_handler.c
> @@ -29,6 +29,7 @@ struct radeon_atpx {
>  	acpi_handle handle;
>  	struct radeon_atpx_functions functions;
>  	bool is_hybrid;
> +	bool dgpu_req_power_for_displays;
>  };
>  
>  static struct radeon_atpx_priv {
> @@ -72,6 +73,10 @@ bool radeon_is_atpx_hybrid(void) {
>  	return radeon_atpx_priv.atpx.is_hybrid;
>  }
>  
> +bool radeon_atpx_dgpu_req_power_for_displays(void) {
> +	return radeon_atpx_priv.atpx.dgpu_req_power_for_displays;
> +}
> +
>  /**
>   * radeon_atpx_call - call an ATPX method
>   *
> -- 
> 2.5.5
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx