From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 02/10] perf, tools: Parse eventcode as number in jevents
Date: Wed, 23 Nov 2016 10:46:19 +0100 [thread overview]
Message-ID: <20161123094619.GB19377@krava> (raw)
In-Reply-To: <1479515780-4702-3-git-send-email-andi@firstfloor.org>
On Fri, Nov 18, 2016 at 04:36:12PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> The next patch needs to modify event code. Previously eventcode was just
> passed through as a string. Now parse it as a number.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/pmu-events/jevents.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> index 41611d7f9873..d343156b1dea 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -135,7 +135,6 @@ static struct field {
> const char *field;
> const char *kernel;
> } fields[] = {
> - { "EventCode", "event=" },
> { "UMask", "umask=" },
> { "CounterMask", "cmask=" },
> { "Invert", "inv=" },
> @@ -164,6 +163,9 @@ static int match_field(char *map, jsmntok_t *field, int nz,
>
> for (f = fields; f->field; f++)
> if (json_streq(map, field, f->field) && nz) {
> + if (json_streq(map, val, "0x00") ||
> + json_streq(map, val, "0x0"))
> + return 1;
why is this needed? could you please put in the comment?
thanks,
jirka
next prev parent reply other threads:[~2016-11-23 9:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-19 0:36 Support Intel uncore event lists in perf Andi Kleen
2016-11-19 0:36 ` [PATCH 01/10] perf, tools: Factor out scale conversion code Andi Kleen
2016-11-23 9:26 ` Jiri Olsa
2016-11-23 9:46 ` Jiri Olsa
2016-11-19 0:36 ` [PATCH 02/10] perf, tools: Parse eventcode as number in jevents Andi Kleen
2016-11-23 9:46 ` Jiri Olsa [this message]
2016-11-19 0:36 ` [PATCH 03/10] perf, tools: Add support for parsing uncore json files Andi Kleen
2016-11-19 0:36 ` [PATCH 04/10] perf, tools: Support per pmu json aliases Andi Kleen
2016-11-19 0:36 ` [PATCH 05/10] perf, tools: Support event aliases for non cpu// pmus Andi Kleen
2016-11-19 0:36 ` [PATCH 06/10] perf, tools: Add debug support for outputing alias string Andi Kleen
2016-11-19 0:36 ` [PATCH 07/10] perf, tools: Collapse identically named events in perf stat Andi Kleen
2016-11-19 0:36 ` [PATCH 08/10] perf, tools: Expand PMU events by prefix match Andi Kleen
2016-11-19 0:36 ` [PATCH 09/10] perf, tools: Support DividedBy header in JSON event list Andi Kleen
2016-11-19 0:36 ` [PATCH 10/10] perf, tools, stat: Output generic dividedby metric Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123094619.GB19377@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.