From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Wed, 23 Nov 2016 09:49:44 +0000 Subject: Re: [RFC PATCH 0/3] staging: remove fbdev drivers Message-Id: <20161123094944.GA17112@kroah.com> List-Id: References: <1479888193-23908-1-git-send-email-tomi.valkeinen@ti.com> <20161123085234.GB3122@kroah.com> <230111fb-498e-11ef-b452-157a36d7f021@ti.com> In-Reply-To: <230111fb-498e-11ef-b452-157a36d7f021@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen Cc: Thomas Petazzoni , linux-fbdev@vger.kernel.org, Teddy Wang , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sudip Mukherjee , Arnaud Patard On Wed, Nov 23, 2016 at 11:12:32AM +0200, Tomi Valkeinen wrote: > On 23/11/16 10:52, Greg Kroah-Hartman wrote: > > On Wed, Nov 23, 2016 at 10:03:10AM +0200, Tomi Valkeinen wrote: > >> Hi, > >> > >> Since the fbdev framework is in maintenance mode and all new display drivers > >> should be made with the DRM framework, remove the fbdev drivers from staging. > >> > >> Note: the patches are created with git format-patch -D, so they can't be > >> applied. Only for review. > > > > I only want to remove these drivers if we have the same functionality in > > mainline for their hardware. If not, that's a bit rude to those who > > actually use them today, don't you think? > > What does it mean for a driver to be in staging? I thought it's > basically the same as the driver being out-of-tree, with the difference > that the code is in a central git repository for easier co-operation. Yes, but it also allows people to use their hardware, for drivers that are not "quite ready". > If that's what staging means, then I would reject the staging fbdev > drivers the same way as I'd reject new fbdev drivers sent as patches to > the list. Rejecting valid drivers for hardware that people have today is not a nice thing. If you want to just move them into staging so that people can get their hardware working while people port to the new apis, I will be glad to take them. > Or do you mean that we should keep the drivers in staging until there's > a matching DRM driver, but drop any plans to move the drivers from > staging to drivers/video/? If so, I'm fine with that. This is an RFC, > mostly to raise some discussion and push people to actually write those > DRM drivers =). I do not want to move these to drivers/video/ and they should just stay where they are until a matching DRM driver is present in the tree. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [RFC PATCH 0/3] staging: remove fbdev drivers Date: Wed, 23 Nov 2016 10:49:44 +0100 Message-ID: <20161123094944.GA17112@kroah.com> References: <1479888193-23908-1-git-send-email-tomi.valkeinen@ti.com> <20161123085234.GB3122@kroah.com> <230111fb-498e-11ef-b452-157a36d7f021@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A88A6E7A9 for ; Wed, 23 Nov 2016 09:49:35 +0000 (UTC) Content-Disposition: inline In-Reply-To: <230111fb-498e-11ef-b452-157a36d7f021@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: Thomas Petazzoni , linux-fbdev@vger.kernel.org, Teddy Wang , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sudip Mukherjee , Arnaud Patard List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMjMsIDIwMTYgYXQgMTE6MTI6MzJBTSArMDIwMCwgVG9taSBWYWxrZWluZW4g d3JvdGU6Cj4gT24gMjMvMTEvMTYgMTA6NTIsIEdyZWcgS3JvYWgtSGFydG1hbiB3cm90ZToKPiA+ IE9uIFdlZCwgTm92IDIzLCAyMDE2IGF0IDEwOjAzOjEwQU0gKzAyMDAsIFRvbWkgVmFsa2VpbmVu IHdyb3RlOgo+ID4+IEhpLAo+ID4+Cj4gPj4gU2luY2UgdGhlIGZiZGV2IGZyYW1ld29yayBpcyBp biBtYWludGVuYW5jZSBtb2RlIGFuZCBhbGwgbmV3IGRpc3BsYXkgZHJpdmVycwo+ID4+IHNob3Vs ZCBiZSBtYWRlIHdpdGggdGhlIERSTSBmcmFtZXdvcmssIHJlbW92ZSB0aGUgZmJkZXYgZHJpdmVy cyBmcm9tIHN0YWdpbmcuCj4gPj4KPiA+PiBOb3RlOiB0aGUgcGF0Y2hlcyBhcmUgY3JlYXRlZCB3 aXRoIGdpdCBmb3JtYXQtcGF0Y2ggLUQsIHNvIHRoZXkgY2FuJ3QgYmUKPiA+PiBhcHBsaWVkLiBP bmx5IGZvciByZXZpZXcuCj4gPiAKPiA+IEkgb25seSB3YW50IHRvIHJlbW92ZSB0aGVzZSBkcml2 ZXJzIGlmIHdlIGhhdmUgdGhlIHNhbWUgZnVuY3Rpb25hbGl0eSBpbgo+ID4gbWFpbmxpbmUgZm9y IHRoZWlyIGhhcmR3YXJlLiAgSWYgbm90LCB0aGF0J3MgYSBiaXQgcnVkZSB0byB0aG9zZSB3aG8K PiA+IGFjdHVhbGx5IHVzZSB0aGVtIHRvZGF5LCBkb24ndCB5b3UgdGhpbms/Cj4gCj4gV2hhdCBk b2VzIGl0IG1lYW4gZm9yIGEgZHJpdmVyIHRvIGJlIGluIHN0YWdpbmc/IEkgdGhvdWdodCBpdCdz Cj4gYmFzaWNhbGx5IHRoZSBzYW1lIGFzIHRoZSBkcml2ZXIgYmVpbmcgb3V0LW9mLXRyZWUsIHdp dGggdGhlIGRpZmZlcmVuY2UKPiB0aGF0IHRoZSBjb2RlIGlzIGluIGEgY2VudHJhbCBnaXQgcmVw b3NpdG9yeSBmb3IgZWFzaWVyIGNvLW9wZXJhdGlvbi4KClllcywgYnV0IGl0IGFsc28gYWxsb3dz IHBlb3BsZSB0byB1c2UgdGhlaXIgaGFyZHdhcmUsIGZvciBkcml2ZXJzIHRoYXQKYXJlIG5vdCAi cXVpdGUgcmVhZHkiLgoKPiBJZiB0aGF0J3Mgd2hhdCBzdGFnaW5nIG1lYW5zLCB0aGVuIEkgd291 bGQgcmVqZWN0IHRoZSBzdGFnaW5nIGZiZGV2Cj4gZHJpdmVycyB0aGUgc2FtZSB3YXkgYXMgSSdk IHJlamVjdCBuZXcgZmJkZXYgZHJpdmVycyBzZW50IGFzIHBhdGNoZXMgdG8KPiB0aGUgbGlzdC4K ClJlamVjdGluZyB2YWxpZCBkcml2ZXJzIGZvciBoYXJkd2FyZSB0aGF0IHBlb3BsZSBoYXZlIHRv ZGF5IGlzIG5vdCBhCm5pY2UgdGhpbmcuICBJZiB5b3Ugd2FudCB0byBqdXN0IG1vdmUgdGhlbSBp bnRvIHN0YWdpbmcgc28gdGhhdCBwZW9wbGUKY2FuIGdldCB0aGVpciBoYXJkd2FyZSB3b3JraW5n IHdoaWxlIHBlb3BsZSBwb3J0IHRvIHRoZSBuZXcgYXBpcywgSSB3aWxsCmJlIGdsYWQgdG8gdGFr ZSB0aGVtLgoKPiBPciBkbyB5b3UgbWVhbiB0aGF0IHdlIHNob3VsZCBrZWVwIHRoZSBkcml2ZXJz IGluIHN0YWdpbmcgdW50aWwgdGhlcmUncwo+IGEgbWF0Y2hpbmcgRFJNIGRyaXZlciwgYnV0IGRy b3AgYW55IHBsYW5zIHRvIG1vdmUgdGhlIGRyaXZlcnMgZnJvbQo+IHN0YWdpbmcgdG8gZHJpdmVy cy92aWRlby8/IElmIHNvLCBJJ20gZmluZSB3aXRoIHRoYXQuIFRoaXMgaXMgYW4gUkZDLAo+IG1v c3RseSB0byByYWlzZSBzb21lIGRpc2N1c3Npb24gYW5kIHB1c2ggcGVvcGxlIHRvIGFjdHVhbGx5 IHdyaXRlIHRob3NlCj4gRFJNIGRyaXZlcnMgPSkuCgpJIGRvIG5vdCB3YW50IHRvIG1vdmUgdGhl c2UgdG8gZHJpdmVycy92aWRlby8gYW5kIHRoZXkgc2hvdWxkIGp1c3Qgc3RheQp3aGVyZSB0aGV5 IGFyZSB1bnRpbCBhIG1hdGNoaW5nIERSTSBkcml2ZXIgaXMgcHJlc2VudCBpbiB0aGUgdHJlZS4K CnRoYW5rcywKCmdyZWcgay1oCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934955AbcKWKA0 (ORCPT ); Wed, 23 Nov 2016 05:00:26 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42578 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934904AbcKWJ6x (ORCPT ); Wed, 23 Nov 2016 04:58:53 -0500 Date: Wed, 23 Nov 2016 10:49:44 +0100 From: Greg Kroah-Hartman To: Tomi Valkeinen Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Petazzoni , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Sudip Mukherjee , Teddy Wang , Arnaud Patard , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/3] staging: remove fbdev drivers Message-ID: <20161123094944.GA17112@kroah.com> References: <1479888193-23908-1-git-send-email-tomi.valkeinen@ti.com> <20161123085234.GB3122@kroah.com> <230111fb-498e-11ef-b452-157a36d7f021@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <230111fb-498e-11ef-b452-157a36d7f021@ti.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 23, 2016 at 11:12:32AM +0200, Tomi Valkeinen wrote: > On 23/11/16 10:52, Greg Kroah-Hartman wrote: > > On Wed, Nov 23, 2016 at 10:03:10AM +0200, Tomi Valkeinen wrote: > >> Hi, > >> > >> Since the fbdev framework is in maintenance mode and all new display drivers > >> should be made with the DRM framework, remove the fbdev drivers from staging. > >> > >> Note: the patches are created with git format-patch -D, so they can't be > >> applied. Only for review. > > > > I only want to remove these drivers if we have the same functionality in > > mainline for their hardware. If not, that's a bit rude to those who > > actually use them today, don't you think? > > What does it mean for a driver to be in staging? I thought it's > basically the same as the driver being out-of-tree, with the difference > that the code is in a central git repository for easier co-operation. Yes, but it also allows people to use their hardware, for drivers that are not "quite ready". > If that's what staging means, then I would reject the staging fbdev > drivers the same way as I'd reject new fbdev drivers sent as patches to > the list. Rejecting valid drivers for hardware that people have today is not a nice thing. If you want to just move them into staging so that people can get their hardware working while people port to the new apis, I will be glad to take them. > Or do you mean that we should keep the drivers in staging until there's > a matching DRM driver, but drop any plans to move the drivers from > staging to drivers/video/? If so, I'm fine with that. This is an RFC, > mostly to raise some discussion and push people to actually write those > DRM drivers =). I do not want to move these to drivers/video/ and they should just stay where they are until a matching DRM driver is present in the tree. thanks, greg k-h