From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com ([74.125.82.47]:35979 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933629AbcKWJun (ORCPT ); Wed, 23 Nov 2016 04:50:43 -0500 Received: by mail-wm0-f47.google.com with SMTP id g23so69838023wme.1 for ; Wed, 23 Nov 2016 01:50:16 -0800 (PST) Date: Wed, 23 Nov 2016 09:53:17 +0000 From: Lee Jones To: Benjamin Gaignard Cc: robh+dt@kernel.org, mark.rutland@arm.com, alexandre.torgue@st.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, linux-pwm@vger.kernel.org, jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, fabrice.gasnier@st.com, gerald.baeza@st.com, arnaud.pouliquen@st.com, linus.walleij@linaro.org, linaro-kernel@lists.linaro.org, Benjamin Gaignard Subject: Re: [PATCH 7/7] add stm32 multi-functions timer driver in DT Message-ID: <20161123095317.GP10134@dell.home> References: <1479831207-32699-1-git-send-email-benjamin.gaignard@st.com> <1479831207-32699-8-git-send-email-benjamin.gaignard@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <1479831207-32699-8-git-send-email-benjamin.gaignard@st.com> Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Tue, 22 Nov 2016, Benjamin Gaignard wrote: > Add timers MFD and childs into DT for stm32f4. > Define and enable pwm1 and pwm3 for stm32f469 discovery board > > Signed-off-by: Benjamin Gaignard > --- > arch/arm/boot/dts/stm32f429.dtsi | 246 ++++++++++++++++++++++++++++++++++ > arch/arm/boot/dts/stm32f469-disco.dts | 29 ++++ > 2 files changed, 275 insertions(+) > > diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi > index bca491d..28a0fe9 100644 > --- a/arch/arm/boot/dts/stm32f429.dtsi > +++ b/arch/arm/boot/dts/stm32f429.dtsi > @@ -355,6 +355,21 @@ > slew-rate = <2>; > }; > }; > + > + pwm1_pins: pwm@1 { > + pins { > + pinmux = , > + , > + ; > + }; > + }; > + > + pwm3_pins: pwm@3 { > + pins { > + pinmux = , > + ; > + }; > + }; > }; > > rcc: rcc@40023810 { > @@ -426,6 +441,237 @@ > interrupts = <80>; > clocks = <&rcc 0 38>; > }; > + > + mfd_timer1: mfdtimer1@40010000 { Do you reference this node? If not, it should read: advanced-control@40010000 > + compatible = "st,stm32-mfd-timer1"; "st,stm32-advanced-control" > + reg = <0x40010000 0x400>; > + clocks = <&rcc 0 160>; > + clock-names = "mfd_timer_clk"; "clk_int" > + interrupts = <27>; This is a timer property. Also move the associated registration C code into the timer driver. > + status = "disabled"; > + > + pwm1: pwm1@40010000 { pwm@0 { > + compatible = "st,stm32-pwm1"; st,stm32-advanced-control-pwm > + status = "disabled"; > + }; > + > + iiotimer1: iiotimer1@40010000 { Same here: timer@0 > + compatible = "st,stm32-iio-timer1"; st,stm32-advanced-control-timer > + status = "disabled"; > + }; > + }; > + > + mfd_timer2: mfdtimer2@40000000 { > + compatible = "st,stm32-mfd-timer2"; > + reg = <0x40000000 0x400>; > + clocks = <&rcc 0 128>; > + clock-names = "mfd_timer_clk"; > + interrupts = <28>; > + status = "disabled"; > + > + pwm2: pwm2@40000000 { > + compatible = "st,stm32-pwm2"; > + status = "disabled"; > + }; > + iiotimer2: iiotimer2@40000000 { > + compatible = "st,stm32-iio-timer2"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer3: mfdtimer3@40000400 { > + compatible = "st,stm32-mfd-timer3"; > + reg = <0x40000400 0x400>; > + clocks = <&rcc 0 129>; > + clock-names = "mfd_timer_clk"; > + interrupts = <29>; > + status = "disabled"; > + > + pwm3: pwm3@40000400 { > + compatible = "st,stm32-pwm3"; > + status = "disabled"; > + }; > + iiotimer3: iiotimer3@40000400 { > + compatible = "st,stm32-iio-timer3"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer4: mfdtimer4@40000800 { > + compatible = "st,stm32-mfd-timer4"; > + reg = <0x40000800 0x400>; > + clocks = <&rcc 0 130>; > + clock-names = "mfd_timer_clk"; > + interrupts = <30>; > + status = "disabled"; > + > + pwm4: pwm4@40000800 { > + compatible = "st,stm32-pwm4"; > + status = "disabled"; > + }; > + iiotimer4: iiotimer4@40000800 { > + compatible = "st,stm32-iio-timer4"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer5: mfdtimer5@40000C00 { > + compatible = "st,stm32-mfd-timer5"; > + reg = <0x40000C00 0x400>; > + clocks = <&rcc 0 131>; > + clock-names = "mfd_timer_clk"; > + interrupts = <50>; > + status = "disabled"; > + > + pwm5: pwm5@40000C00 { > + compatible = "st,stm32-pwm5"; > + status = "disabled"; > + }; > + iiotimer5: iiotimer5@40000800 { > + compatible = "st,stm32-iio-timer5"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer6: mfdtimer6@40001000 { > + compatible = "st,stm32-mfd-timer6"; > + reg = <0x40001000 0x400>; > + clocks = <&rcc 0 132>; > + clock-names = "mfd_timer_clk"; > + interrupts = <54>; > + status = "disabled"; > + > + iiotimer6: iiotimer6@40001000 { > + compatible = "st,stm32-iio-timer6"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer7: mfdtimer7@40001400 { > + compatible = "st,stm32-mfd-timer7"; > + reg = <0x40001400 0x400>; > + clocks = <&rcc 0 133>; > + clock-names = "mfd_timer_clk"; > + interrupts = <55>; > + status = "disabled"; > + > + iiotimer7: iiotimer7@40001400 { > + compatible = "st,stm32-iio-timer7"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer8: mfdtimer8@40010400 { > + compatible = "st,stm32-mfd-timer8"; > + reg = <0x40010400 0x400>; > + clocks = <&rcc 0 161>; > + clock-names = "mfd_timer_clk"; > + interrupts = <46>; > + status = "disabled"; > + > + pwm8: pwm8@40010400 { > + compatible = "st,stm32-pwm8"; > + status = "disabled"; > + }; > + > + iiotimer8: iiotimer7@40010400 { > + compatible = "st,stm32-iio-timer8"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer9: mfdtimer9@40014000 { > + compatible = "st,stm32-mfd-timer9"; > + reg = <0x40014000 0x400>; > + clocks = <&rcc 0 176>; > + clock-names = "mfd_timer_clk"; > + interrupts = <24>; > + status = "disabled"; > + > + pwm9: pwm9@40014000 { > + compatible = "st,stm32-pwm9"; > + status = "disabled"; > + }; > + > + iiotimer9: iiotimer9@40014000 { > + compatible = "st,stm32-iio-timer9"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer10: mfdtimer10@40014400 { > + compatible = "st,stm32-mfd-timer10"; > + reg = <0x40014400 0x400>; > + clocks = <&rcc 0 177>; > + clock-names = "mfd_timer_clk"; > + interrupts = <25>; > + status = "disabled"; > + > + pwm10: pwm10@40014400 { > + compatible = "st,stm32-pwm10"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer11: mfdtimer11@40014800 { > + compatible = "st,stm32-mfd-timer11"; > + reg = <0x40014800 0x400>; > + clocks = <&rcc 0 178>; > + clock-names = "mfd_timer_clk"; > + interrupts = <26>; > + status = "disabled"; > + > + pwm11: pwm11@40014800 { > + compatible = "st,stm32-pwm11"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer12: mfdtimer12@40001800 { > + compatible = "st,stm32-mfd-timer12"; > + reg = <0x40001800 0x400>; > + clocks = <&rcc 0 134>; > + clock-names = "mfd_timer_clk"; > + interrupts = <43>; > + status = "disabled"; > + > + pwm12: pwm12@40001800 { > + compatible = "st,stm32-pwm12"; > + status = "disabled"; > + }; > + iiotimer12: iiotimer12@40001800 { > + compatible = "st,stm32-iio-timer12"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer13: mfdtimer13@40001C00 { > + compatible = "st,stm32-mfd-timer13"; > + reg = <0x40001C00 0x400>; > + clocks = <&rcc 0 135>; > + clock-names = "mfd_timer_clk"; > + interrupts = <44>; > + status = "disabled"; > + > + pwm13: pwm13@40001C00 { > + compatible = "st,stm32-pwm13"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer14: mfdtimer14@40002000 { > + compatible = "st,stm32-mfd-timer14"; > + reg = <0x40002000 0x400>; > + clocks = <&rcc 0 136>; > + clock-names = "mfd_timer_clk"; > + interrupts = <45>; > + status = "disabled"; > + > + pwm14: pwm14@40002000 { > + compatible = "st,stm32-pwm14"; > + status = "disabled"; > + }; > + }; > }; > }; > > diff --git a/arch/arm/boot/dts/stm32f469-disco.dts b/arch/arm/boot/dts/stm32f469-disco.dts > index 8a163d7..a8f1788 100644 > --- a/arch/arm/boot/dts/stm32f469-disco.dts > +++ b/arch/arm/boot/dts/stm32f469-disco.dts > @@ -81,3 +81,32 @@ > &usart3 { > status = "okay"; > }; > + > +&mfd_timer1 { > + status = "okay"; > +}; > + > +&pwm1 { > + pinctrl-0 = <&pwm1_pins>; > + pinctrl-names = "default"; > + st,breakinput-polarity = <0>; Is this documented? I'm sure we have generic polarity properties somewhere already? > + status = "okay"; > +}; > + > +&iiotimer1 { > + status = "okay"; > +}; > + > +&mfd_timer3 { > + status = "okay"; > +}; > + > +&pwm3 { > + pinctrl-0 = <&pwm3_pins>; > + pinctrl-names = "default"; > + status = "okay"; > +}; > + > +&iiotimer3 { > + status = "okay"; > +}; I've always disliked this way of referencing nodes! Any chance we can represent them in a hierarchy, so we don't lose that information and we can get rid of all those horrible labels? I'm happy to do the work. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 7/7] add stm32 multi-functions timer driver in DT Date: Wed, 23 Nov 2016 09:53:17 +0000 Message-ID: <20161123095317.GP10134@dell.home> References: <1479831207-32699-1-git-send-email-benjamin.gaignard@st.com> <1479831207-32699-8-git-send-email-benjamin.gaignard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1479831207-32699-8-git-send-email-benjamin.gaignard@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Benjamin Gaignard Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, lars@metafoo.de, alexandre.torgue@st.com, linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org, linus.walleij@linaro.org, arnaud.pouliquen@st.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, thierry.reding@gmail.com, linux-arm-kernel@lists.infradead.org, pmeerw@pmeerw.net, knaack.h@gmx.de, gerald.baeza@st.com, fabrice.gasnier@st.com, linaro-kernel@lists.linaro.org, jic23@kernel.org, Benjamin Gaignard List-Id: linux-pwm@vger.kernel.org T24gVHVlLCAyMiBOb3YgMjAxNiwgQmVuamFtaW4gR2FpZ25hcmQgd3JvdGU6Cgo+IEFkZCB0aW1l cnMgTUZEIGFuZCBjaGlsZHMgaW50byBEVCBmb3Igc3RtMzJmNC4KPiBEZWZpbmUgYW5kIGVuYWJs ZSBwd20xIGFuZCBwd20zIGZvciBzdG0zMmY0NjkgZGlzY292ZXJ5IGJvYXJkCj4gCj4gU2lnbmVk LW9mZi1ieTogQmVuamFtaW4gR2FpZ25hcmQgPGJlbmphbWluLmdhaWduYXJkQHN0LmNvbT4KPiAt LS0KPiAgYXJjaC9hcm0vYm9vdC9kdHMvc3RtMzJmNDI5LmR0c2kgICAgICB8IDI0NiArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGFyY2gvYXJtL2Jvb3QvZHRzL3N0bTMyZjQ2 OS1kaXNjby5kdHMgfCAgMjkgKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDI3NSBpbnNlcnRpb25z KCspCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL3N0bTMyZjQyOS5kdHNpIGIv YXJjaC9hcm0vYm9vdC9kdHMvc3RtMzJmNDI5LmR0c2kKPiBpbmRleCBiY2E0OTFkLi4yOGEwZmU5 IDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRzL3N0bTMyZjQyOS5kdHNpCj4gKysrIGIv YXJjaC9hcm0vYm9vdC9kdHMvc3RtMzJmNDI5LmR0c2kKPiBAQCAtMzU1LDYgKzM1NSwyMSBAQAo+ ICAJCQkJCXNsZXctcmF0ZSA9IDwyPjsKPiAgCQkJCX07Cj4gIAkJCX07Cj4gKwo+ICsJCQlwd20x X3BpbnM6IHB3bUAxIHsKPiArCQkJCXBpbnMgewo+ICsJCQkJCXBpbm11eCA9IDxTVE0zMkY0Mjlf UEE4X0ZVTkNfVElNMV9DSDE+LAo+ICsJCQkJCQkgPFNUTTMyRjQyOV9QQjEzX0ZVTkNfVElNMV9D SDFOPiwKPiArCQkJCQkJIDxTVE0zMkY0MjlfUEIxMl9GVU5DX1RJTTFfQktJTj47Cj4gKwkJCQl9 Owo+ICsJCQl9Owo+ICsKPiArCQkJcHdtM19waW5zOiBwd21AMyB7Cj4gKwkJCQlwaW5zIHsKPiAr CQkJCQlwaW5tdXggPSA8U1RNMzJGNDI5X1BCNF9GVU5DX1RJTTNfQ0gxPiwKPiArCQkJCQkJIDxT VE0zMkY0MjlfUEI1X0ZVTkNfVElNM19DSDI+Owo+ICsJCQkJfTsKPiArCQkJfTsKPiAgCQl9Owo+ ICAKPiAgCQlyY2M6IHJjY0A0MDAyMzgxMCB7Cj4gQEAgLTQyNiw2ICs0NDEsMjM3IEBACj4gIAkJ CWludGVycnVwdHMgPSA8ODA+Owo+ICAJCQljbG9ja3MgPSA8JnJjYyAwIDM4PjsKPiAgCQl9Owo+ ICsKPiArCQltZmRfdGltZXIxOiBtZmR0aW1lcjFANDAwMTAwMDAgewoKRG8geW91IHJlZmVyZW5j ZSB0aGlzIG5vZGU/CgpJZiBub3QsIGl0IHNob3VsZCByZWFkOgoKICBhZHZhbmNlZC1jb250cm9s QDQwMDEwMDAwCgo+ICsJCQljb21wYXRpYmxlID0gInN0LHN0bTMyLW1mZC10aW1lcjEiOwoKInN0 LHN0bTMyLWFkdmFuY2VkLWNvbnRyb2wiCgo+ICsJCQlyZWcgPSA8MHg0MDAxMDAwMCAweDQwMD47 Cj4gKwkJCWNsb2NrcyA9IDwmcmNjIDAgMTYwPjsKPiArCQkJY2xvY2stbmFtZXMgPSAibWZkX3Rp bWVyX2NsayI7CgoiY2xrX2ludCIKCj4gKwkJCWludGVycnVwdHMgPSA8Mjc+OwoKVGhpcyBpcyBh IHRpbWVyIHByb3BlcnR5LgoKQWxzbyBtb3ZlIHRoZSBhc3NvY2lhdGVkIHJlZ2lzdHJhdGlvbiBD IGNvZGUgaW50byB0aGUgdGltZXIgZHJpdmVyLgoKPiArCQkJc3RhdHVzID0gImRpc2FibGVkIjsK PiArCj4gKwkJCXB3bTE6IHB3bTFANDAwMTAwMDAgewoKICBwd21AMCB7Cgo+ICsJCQkJY29tcGF0 aWJsZSA9ICJzdCxzdG0zMi1wd20xIjsKCnN0LHN0bTMyLWFkdmFuY2VkLWNvbnRyb2wtcHdtCgo+ ICsJCQkJc3RhdHVzID0gImRpc2FibGVkIjsKPiArCQkJfTsKPiArCj4gKwkJCWlpb3RpbWVyMTog aWlvdGltZXIxQDQwMDEwMDAwIHsKClNhbWUgaGVyZToKCiAgdGltZXJAMAoKPiArCQkJCWNvbXBh dGlibGUgPSAic3Qsc3RtMzItaWlvLXRpbWVyMSI7CgpzdCxzdG0zMi1hZHZhbmNlZC1jb250cm9s LXRpbWVyCgo+ICsJCQkJc3RhdHVzID0gImRpc2FibGVkIjsKPiArCQkJfTsKPiArCQl9Owo+ICsK PiArCQltZmRfdGltZXIyOiBtZmR0aW1lcjJANDAwMDAwMDAgewo+ICsJCQljb21wYXRpYmxlID0g InN0LHN0bTMyLW1mZC10aW1lcjIiOwo+ICsJCQlyZWcgPSA8MHg0MDAwMDAwMCAweDQwMD47Cj4g KwkJCWNsb2NrcyA9IDwmcmNjIDAgMTI4PjsKPiArCQkJY2xvY2stbmFtZXMgPSAibWZkX3RpbWVy X2NsayI7Cj4gKwkJCWludGVycnVwdHMgPSA8Mjg+Owo+ICsJCQlzdGF0dXMgPSAiZGlzYWJsZWQi Owo+ICsKPiArCQkJcHdtMjogcHdtMkA0MDAwMDAwMCB7Cj4gKwkJCQljb21wYXRpYmxlID0gInN0 LHN0bTMyLXB3bTIiOwo+ICsJCQkJc3RhdHVzID0gImRpc2FibGVkIjsKPiArCQkJfTsKPiArCQkJ aWlvdGltZXIyOiBpaW90aW1lcjJANDAwMDAwMDAgewo+ICsJCQkJY29tcGF0aWJsZSA9ICJzdCxz dG0zMi1paW8tdGltZXIyIjsKPiArCQkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gKwkJCX07Cj4g KwkJfTsKPiArCj4gKwkJbWZkX3RpbWVyMzogbWZkdGltZXIzQDQwMDAwNDAwIHsKPiArCQkJY29t cGF0aWJsZSA9ICJzdCxzdG0zMi1tZmQtdGltZXIzIjsKPiArCQkJcmVnID0gPDB4NDAwMDA0MDAg MHg0MDA+Owo+ICsJCQljbG9ja3MgPSA8JnJjYyAwIDEyOT47Cj4gKwkJCWNsb2NrLW5hbWVzID0g Im1mZF90aW1lcl9jbGsiOwo+ICsJCQlpbnRlcnJ1cHRzID0gPDI5PjsKPiArCQkJc3RhdHVzID0g ImRpc2FibGVkIjsKPiArCj4gKwkJCXB3bTM6IHB3bTNANDAwMDA0MDAgewo+ICsJCQkJY29tcGF0 aWJsZSA9ICJzdCxzdG0zMi1wd20zIjsKPiArCQkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gKwkJ CX07Cj4gKwkJCWlpb3RpbWVyMzogaWlvdGltZXIzQDQwMDAwNDAwIHsKPiArCQkJCWNvbXBhdGli bGUgPSAic3Qsc3RtMzItaWlvLXRpbWVyMyI7Cj4gKwkJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ ICsJCQl9Owo+ICsJCX07Cj4gKwo+ICsJCW1mZF90aW1lcjQ6IG1mZHRpbWVyNEA0MDAwMDgwMCB7 Cj4gKwkJCWNvbXBhdGlibGUgPSAic3Qsc3RtMzItbWZkLXRpbWVyNCI7Cj4gKwkJCXJlZyA9IDww eDQwMDAwODAwIDB4NDAwPjsKPiArCQkJY2xvY2tzID0gPCZyY2MgMCAxMzA+Owo+ICsJCQljbG9j ay1uYW1lcyA9ICJtZmRfdGltZXJfY2xrIjsKPiArCQkJaW50ZXJydXB0cyA9IDwzMD47Cj4gKwkJ CXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gKwo+ICsJCQlwd200OiBwd200QDQwMDAwODAwIHsKPiAr CQkJCWNvbXBhdGlibGUgPSAic3Qsc3RtMzItcHdtNCI7Cj4gKwkJCQlzdGF0dXMgPSAiZGlzYWJs ZWQiOwo+ICsJCQl9Owo+ICsJCQlpaW90aW1lcjQ6IGlpb3RpbWVyNEA0MDAwMDgwMCB7Cj4gKwkJ CQljb21wYXRpYmxlID0gInN0LHN0bTMyLWlpby10aW1lcjQiOwo+ICsJCQkJc3RhdHVzID0gImRp c2FibGVkIjsKPiArCQkJfTsKPiArCQl9Owo+ICsKPiArCQltZmRfdGltZXI1OiBtZmR0aW1lcjVA NDAwMDBDMDAgewo+ICsJCQljb21wYXRpYmxlID0gInN0LHN0bTMyLW1mZC10aW1lcjUiOwo+ICsJ CQlyZWcgPSA8MHg0MDAwMEMwMCAweDQwMD47Cj4gKwkJCWNsb2NrcyA9IDwmcmNjIDAgMTMxPjsK PiArCQkJY2xvY2stbmFtZXMgPSAibWZkX3RpbWVyX2NsayI7Cj4gKwkJCWludGVycnVwdHMgPSA8 NTA+Owo+ICsJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ICsKPiArCQkJcHdtNTogcHdtNUA0MDAw MEMwMCB7Cj4gKwkJCQljb21wYXRpYmxlID0gInN0LHN0bTMyLXB3bTUiOwo+ICsJCQkJc3RhdHVz ID0gImRpc2FibGVkIjsKPiArCQkJfTsKPiArCQkJaWlvdGltZXI1OiBpaW90aW1lcjVANDAwMDA4 MDAgewo+ICsJCQkJY29tcGF0aWJsZSA9ICJzdCxzdG0zMi1paW8tdGltZXI1IjsKPiArCQkJCXN0 YXR1cyA9ICJkaXNhYmxlZCI7Cj4gKwkJCX07Cj4gKwkJfTsKPiArCj4gKwkJbWZkX3RpbWVyNjog bWZkdGltZXI2QDQwMDAxMDAwIHsKPiArCQkJY29tcGF0aWJsZSA9ICJzdCxzdG0zMi1tZmQtdGlt ZXI2IjsKPiArCQkJcmVnID0gPDB4NDAwMDEwMDAgMHg0MDA+Owo+ICsJCQljbG9ja3MgPSA8JnJj YyAwIDEzMj47Cj4gKwkJCWNsb2NrLW5hbWVzID0gIm1mZF90aW1lcl9jbGsiOwo+ICsJCQlpbnRl cnJ1cHRzID0gPDU0PjsKPiArCQkJc3RhdHVzID0gImRpc2FibGVkIjsKPiArCj4gKwkJCWlpb3Rp bWVyNjogaWlvdGltZXI2QDQwMDAxMDAwIHsKPiArCQkJCWNvbXBhdGlibGUgPSAic3Qsc3RtMzIt aWlvLXRpbWVyNiI7Cj4gKwkJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ICsJCQl9Owo+ICsJCX07 Cj4gKwo+ICsJCW1mZF90aW1lcjc6IG1mZHRpbWVyN0A0MDAwMTQwMCB7Cj4gKwkJCWNvbXBhdGli bGUgPSAic3Qsc3RtMzItbWZkLXRpbWVyNyI7Cj4gKwkJCXJlZyA9IDwweDQwMDAxNDAwIDB4NDAw PjsKPiArCQkJY2xvY2tzID0gPCZyY2MgMCAxMzM+Owo+ICsJCQljbG9jay1uYW1lcyA9ICJtZmRf dGltZXJfY2xrIjsKPiArCQkJaW50ZXJydXB0cyA9IDw1NT47Cj4gKwkJCXN0YXR1cyA9ICJkaXNh YmxlZCI7Cj4gKwo+ICsJCQlpaW90aW1lcjc6IGlpb3RpbWVyN0A0MDAwMTQwMCB7Cj4gKwkJCQlj b21wYXRpYmxlID0gInN0LHN0bTMyLWlpby10aW1lcjciOwo+ICsJCQkJc3RhdHVzID0gImRpc2Fi bGVkIjsKPiArCQkJfTsKPiArCQl9Owo+ICsKPiArCQltZmRfdGltZXI4OiBtZmR0aW1lcjhANDAw MTA0MDAgewo+ICsJCQljb21wYXRpYmxlID0gInN0LHN0bTMyLW1mZC10aW1lcjgiOwo+ICsJCQly ZWcgPSA8MHg0MDAxMDQwMCAweDQwMD47Cj4gKwkJCWNsb2NrcyA9IDwmcmNjIDAgMTYxPjsKPiAr CQkJY2xvY2stbmFtZXMgPSAibWZkX3RpbWVyX2NsayI7Cj4gKwkJCWludGVycnVwdHMgPSA8NDY+ Owo+ICsJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ICsKPiArCQkJcHdtODogcHdtOEA0MDAxMDQw MCB7Cj4gKwkJCQljb21wYXRpYmxlID0gInN0LHN0bTMyLXB3bTgiOwo+ICsJCQkJc3RhdHVzID0g ImRpc2FibGVkIjsKPiArCQkJfTsKPiArCj4gKwkJCWlpb3RpbWVyODogaWlvdGltZXI3QDQwMDEw NDAwIHsKPiArCQkJCWNvbXBhdGlibGUgPSAic3Qsc3RtMzItaWlvLXRpbWVyOCI7Cj4gKwkJCQlz dGF0dXMgPSAiZGlzYWJsZWQiOwo+ICsJCQl9Owo+ICsJCX07Cj4gKwo+ICsJCW1mZF90aW1lcjk6 IG1mZHRpbWVyOUA0MDAxNDAwMCB7Cj4gKwkJCWNvbXBhdGlibGUgPSAic3Qsc3RtMzItbWZkLXRp bWVyOSI7Cj4gKwkJCXJlZyA9IDwweDQwMDE0MDAwIDB4NDAwPjsKPiArCQkJY2xvY2tzID0gPCZy Y2MgMCAxNzY+Owo+ICsJCQljbG9jay1uYW1lcyA9ICJtZmRfdGltZXJfY2xrIjsKPiArCQkJaW50 ZXJydXB0cyA9IDwyND47Cj4gKwkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gKwo+ICsJCQlwd205 OiBwd205QDQwMDE0MDAwIHsKPiArCQkJCWNvbXBhdGlibGUgPSAic3Qsc3RtMzItcHdtOSI7Cj4g KwkJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ICsJCQl9Owo+ICsKPiArCQkJaWlvdGltZXI5OiBp aW90aW1lcjlANDAwMTQwMDAgewo+ICsJCQkJY29tcGF0aWJsZSA9ICJzdCxzdG0zMi1paW8tdGlt ZXI5IjsKPiArCQkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gKwkJCX07Cj4gKwkJfTsKPiArCj4g KwkJbWZkX3RpbWVyMTA6IG1mZHRpbWVyMTBANDAwMTQ0MDAgewo+ICsJCQljb21wYXRpYmxlID0g InN0LHN0bTMyLW1mZC10aW1lcjEwIjsKPiArCQkJcmVnID0gPDB4NDAwMTQ0MDAgMHg0MDA+Owo+ ICsJCQljbG9ja3MgPSA8JnJjYyAwIDE3Nz47Cj4gKwkJCWNsb2NrLW5hbWVzID0gIm1mZF90aW1l cl9jbGsiOwo+ICsJCQlpbnRlcnJ1cHRzID0gPDI1PjsKPiArCQkJc3RhdHVzID0gImRpc2FibGVk IjsKPiArCj4gKwkJCXB3bTEwOiBwd20xMEA0MDAxNDQwMCB7Cj4gKwkJCQljb21wYXRpYmxlID0g InN0LHN0bTMyLXB3bTEwIjsKPiArCQkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gKwkJCX07Cj4g KwkJfTsKPiArCj4gKwkJbWZkX3RpbWVyMTE6IG1mZHRpbWVyMTFANDAwMTQ4MDAgewo+ICsJCQlj b21wYXRpYmxlID0gInN0LHN0bTMyLW1mZC10aW1lcjExIjsKPiArCQkJcmVnID0gPDB4NDAwMTQ4 MDAgMHg0MDA+Owo+ICsJCQljbG9ja3MgPSA8JnJjYyAwIDE3OD47Cj4gKwkJCWNsb2NrLW5hbWVz ID0gIm1mZF90aW1lcl9jbGsiOwo+ICsJCQlpbnRlcnJ1cHRzID0gPDI2PjsKPiArCQkJc3RhdHVz ID0gImRpc2FibGVkIjsKPiArCj4gKwkJCXB3bTExOiBwd20xMUA0MDAxNDgwMCB7Cj4gKwkJCQlj b21wYXRpYmxlID0gInN0LHN0bTMyLXB3bTExIjsKPiArCQkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7 Cj4gKwkJCX07Cj4gKwkJfTsKPiArCj4gKwkJbWZkX3RpbWVyMTI6IG1mZHRpbWVyMTJANDAwMDE4 MDAgewo+ICsJCQljb21wYXRpYmxlID0gInN0LHN0bTMyLW1mZC10aW1lcjEyIjsKPiArCQkJcmVn ID0gPDB4NDAwMDE4MDAgMHg0MDA+Owo+ICsJCQljbG9ja3MgPSA8JnJjYyAwIDEzND47Cj4gKwkJ CWNsb2NrLW5hbWVzID0gIm1mZF90aW1lcl9jbGsiOwo+ICsJCQlpbnRlcnJ1cHRzID0gPDQzPjsK PiArCQkJc3RhdHVzID0gImRpc2FibGVkIjsKPiArCj4gKwkJCXB3bTEyOiBwd20xMkA0MDAwMTgw MCB7Cj4gKwkJCQljb21wYXRpYmxlID0gInN0LHN0bTMyLXB3bTEyIjsKPiArCQkJCXN0YXR1cyA9 ICJkaXNhYmxlZCI7Cj4gKwkJCX07Cj4gKwkJCWlpb3RpbWVyMTI6IGlpb3RpbWVyMTJANDAwMDE4 MDAgewo+ICsJCQkJY29tcGF0aWJsZSA9ICJzdCxzdG0zMi1paW8tdGltZXIxMiI7Cj4gKwkJCQlz dGF0dXMgPSAiZGlzYWJsZWQiOwo+ICsJCQl9Owo+ICsJCX07Cj4gKwo+ICsJCW1mZF90aW1lcjEz OiBtZmR0aW1lcjEzQDQwMDAxQzAwIHsKPiArCQkJY29tcGF0aWJsZSA9ICJzdCxzdG0zMi1tZmQt dGltZXIxMyI7Cj4gKwkJCXJlZyA9IDwweDQwMDAxQzAwIDB4NDAwPjsKPiArCQkJY2xvY2tzID0g PCZyY2MgMCAxMzU+Owo+ICsJCQljbG9jay1uYW1lcyA9ICJtZmRfdGltZXJfY2xrIjsKPiArCQkJ aW50ZXJydXB0cyA9IDw0ND47Cj4gKwkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gKwo+ICsJCQlw d20xMzogcHdtMTNANDAwMDFDMDAgewo+ICsJCQkJY29tcGF0aWJsZSA9ICJzdCxzdG0zMi1wd20x MyI7Cj4gKwkJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ICsJCQl9Owo+ICsJCX07Cj4gKwo+ICsJ CW1mZF90aW1lcjE0OiBtZmR0aW1lcjE0QDQwMDAyMDAwIHsKPiArCQkJY29tcGF0aWJsZSA9ICJz dCxzdG0zMi1tZmQtdGltZXIxNCI7Cj4gKwkJCXJlZyA9IDwweDQwMDAyMDAwIDB4NDAwPjsKPiAr CQkJY2xvY2tzID0gPCZyY2MgMCAxMzY+Owo+ICsJCQljbG9jay1uYW1lcyA9ICJtZmRfdGltZXJf Y2xrIjsKPiArCQkJaW50ZXJydXB0cyA9IDw0NT47Cj4gKwkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7 Cj4gKwo+ICsJCQlwd20xNDogcHdtMTRANDAwMDIwMDAgewo+ICsJCQkJY29tcGF0aWJsZSA9ICJz dCxzdG0zMi1wd20xNCI7Cj4gKwkJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ICsJCQl9Owo+ICsJ CX07Cj4gIAl9Owo+ICB9Owo+ICAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMvc3Rt MzJmNDY5LWRpc2NvLmR0cyBiL2FyY2gvYXJtL2Jvb3QvZHRzL3N0bTMyZjQ2OS1kaXNjby5kdHMK PiBpbmRleCA4YTE2M2Q3Li5hOGYxNzg4IDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRz L3N0bTMyZjQ2OS1kaXNjby5kdHMKPiArKysgYi9hcmNoL2FybS9ib290L2R0cy9zdG0zMmY0Njkt ZGlzY28uZHRzCj4gQEAgLTgxLDMgKzgxLDMyIEBACj4gICZ1c2FydDMgewo+ICAJc3RhdHVzID0g Im9rYXkiOwo+ICB9Owo+ICsKPiArJm1mZF90aW1lcjEgewo+ICsJc3RhdHVzID0gIm9rYXkiOwo+ ICt9Owo+ICsKPiArJnB3bTEgewo+ICsJcGluY3RybC0wCT0gPCZwd20xX3BpbnM+Owo+ICsJcGlu Y3RybC1uYW1lcwk9ICJkZWZhdWx0IjsKPiArCXN0LGJyZWFraW5wdXQtcG9sYXJpdHkgPSA8MD47 CgpJcyB0aGlzIGRvY3VtZW50ZWQ/CgpJJ20gc3VyZSB3ZSBoYXZlIGdlbmVyaWMgcG9sYXJpdHkg cHJvcGVydGllcyBzb21ld2hlcmUgYWxyZWFkeT8KCj4gKwlzdGF0dXMgPSAib2theSI7Cj4gK307 Cj4gKwo+ICsmaWlvdGltZXIxIHsKPiArCXN0YXR1cyA9ICJva2F5IjsKPiArfTsKPiArCj4gKyZt ZmRfdGltZXIzIHsKPiArCXN0YXR1cyA9ICJva2F5IjsKPiArfTsKPiArCj4gKyZwd20zIHsKPiAr CXBpbmN0cmwtMAk9IDwmcHdtM19waW5zPjsKPiArCXBpbmN0cmwtbmFtZXMJPSAiZGVmYXVsdCI7 Cj4gKwlzdGF0dXMgPSAib2theSI7Cj4gK307Cj4gKwo+ICsmaWlvdGltZXIzIHsKPiArCXN0YXR1 cyA9ICJva2F5IjsKPiArfTsKCkkndmUgYWx3YXlzIGRpc2xpa2VkIHRoaXMgd2F5IG9mIHJlZmVy ZW5jaW5nIG5vZGVzIQoKQW55IGNoYW5jZSB3ZSBjYW4gcmVwcmVzZW50IHRoZW0gaW4gYSBoaWVy YXJjaHksIHNvIHdlIGRvbid0IGxvc2UgdGhhdAppbmZvcm1hdGlvbiBhbmQgd2UgY2FuIGdldCBy aWQgb2YgYWxsIHRob3NlIGhvcnJpYmxlIGxhYmVscz8KCkknbSBoYXBweSB0byBkbyB0aGUgd29y ay4KCi0tIApMZWUgSm9uZXMKTGluYXJvIFNUTWljcm9lbGVjdHJvbmljcyBMYW5kaW5nIFRlYW0g TGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9s bG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Wed, 23 Nov 2016 09:53:17 +0000 Subject: [PATCH 7/7] add stm32 multi-functions timer driver in DT In-Reply-To: <1479831207-32699-8-git-send-email-benjamin.gaignard@st.com> References: <1479831207-32699-1-git-send-email-benjamin.gaignard@st.com> <1479831207-32699-8-git-send-email-benjamin.gaignard@st.com> Message-ID: <20161123095317.GP10134@dell.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 22 Nov 2016, Benjamin Gaignard wrote: > Add timers MFD and childs into DT for stm32f4. > Define and enable pwm1 and pwm3 for stm32f469 discovery board > > Signed-off-by: Benjamin Gaignard > --- > arch/arm/boot/dts/stm32f429.dtsi | 246 ++++++++++++++++++++++++++++++++++ > arch/arm/boot/dts/stm32f469-disco.dts | 29 ++++ > 2 files changed, 275 insertions(+) > > diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi > index bca491d..28a0fe9 100644 > --- a/arch/arm/boot/dts/stm32f429.dtsi > +++ b/arch/arm/boot/dts/stm32f429.dtsi > @@ -355,6 +355,21 @@ > slew-rate = <2>; > }; > }; > + > + pwm1_pins: pwm at 1 { > + pins { > + pinmux = , > + , > + ; > + }; > + }; > + > + pwm3_pins: pwm at 3 { > + pins { > + pinmux = , > + ; > + }; > + }; > }; > > rcc: rcc at 40023810 { > @@ -426,6 +441,237 @@ > interrupts = <80>; > clocks = <&rcc 0 38>; > }; > + > + mfd_timer1: mfdtimer1 at 40010000 { Do you reference this node? If not, it should read: advanced-control at 40010000 > + compatible = "st,stm32-mfd-timer1"; "st,stm32-advanced-control" > + reg = <0x40010000 0x400>; > + clocks = <&rcc 0 160>; > + clock-names = "mfd_timer_clk"; "clk_int" > + interrupts = <27>; This is a timer property. Also move the associated registration C code into the timer driver. > + status = "disabled"; > + > + pwm1: pwm1 at 40010000 { pwm at 0 { > + compatible = "st,stm32-pwm1"; st,stm32-advanced-control-pwm > + status = "disabled"; > + }; > + > + iiotimer1: iiotimer1 at 40010000 { Same here: timer at 0 > + compatible = "st,stm32-iio-timer1"; st,stm32-advanced-control-timer > + status = "disabled"; > + }; > + }; > + > + mfd_timer2: mfdtimer2 at 40000000 { > + compatible = "st,stm32-mfd-timer2"; > + reg = <0x40000000 0x400>; > + clocks = <&rcc 0 128>; > + clock-names = "mfd_timer_clk"; > + interrupts = <28>; > + status = "disabled"; > + > + pwm2: pwm2 at 40000000 { > + compatible = "st,stm32-pwm2"; > + status = "disabled"; > + }; > + iiotimer2: iiotimer2 at 40000000 { > + compatible = "st,stm32-iio-timer2"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer3: mfdtimer3 at 40000400 { > + compatible = "st,stm32-mfd-timer3"; > + reg = <0x40000400 0x400>; > + clocks = <&rcc 0 129>; > + clock-names = "mfd_timer_clk"; > + interrupts = <29>; > + status = "disabled"; > + > + pwm3: pwm3 at 40000400 { > + compatible = "st,stm32-pwm3"; > + status = "disabled"; > + }; > + iiotimer3: iiotimer3 at 40000400 { > + compatible = "st,stm32-iio-timer3"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer4: mfdtimer4 at 40000800 { > + compatible = "st,stm32-mfd-timer4"; > + reg = <0x40000800 0x400>; > + clocks = <&rcc 0 130>; > + clock-names = "mfd_timer_clk"; > + interrupts = <30>; > + status = "disabled"; > + > + pwm4: pwm4 at 40000800 { > + compatible = "st,stm32-pwm4"; > + status = "disabled"; > + }; > + iiotimer4: iiotimer4 at 40000800 { > + compatible = "st,stm32-iio-timer4"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer5: mfdtimer5 at 40000C00 { > + compatible = "st,stm32-mfd-timer5"; > + reg = <0x40000C00 0x400>; > + clocks = <&rcc 0 131>; > + clock-names = "mfd_timer_clk"; > + interrupts = <50>; > + status = "disabled"; > + > + pwm5: pwm5 at 40000C00 { > + compatible = "st,stm32-pwm5"; > + status = "disabled"; > + }; > + iiotimer5: iiotimer5 at 40000800 { > + compatible = "st,stm32-iio-timer5"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer6: mfdtimer6 at 40001000 { > + compatible = "st,stm32-mfd-timer6"; > + reg = <0x40001000 0x400>; > + clocks = <&rcc 0 132>; > + clock-names = "mfd_timer_clk"; > + interrupts = <54>; > + status = "disabled"; > + > + iiotimer6: iiotimer6 at 40001000 { > + compatible = "st,stm32-iio-timer6"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer7: mfdtimer7 at 40001400 { > + compatible = "st,stm32-mfd-timer7"; > + reg = <0x40001400 0x400>; > + clocks = <&rcc 0 133>; > + clock-names = "mfd_timer_clk"; > + interrupts = <55>; > + status = "disabled"; > + > + iiotimer7: iiotimer7 at 40001400 { > + compatible = "st,stm32-iio-timer7"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer8: mfdtimer8 at 40010400 { > + compatible = "st,stm32-mfd-timer8"; > + reg = <0x40010400 0x400>; > + clocks = <&rcc 0 161>; > + clock-names = "mfd_timer_clk"; > + interrupts = <46>; > + status = "disabled"; > + > + pwm8: pwm8 at 40010400 { > + compatible = "st,stm32-pwm8"; > + status = "disabled"; > + }; > + > + iiotimer8: iiotimer7 at 40010400 { > + compatible = "st,stm32-iio-timer8"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer9: mfdtimer9 at 40014000 { > + compatible = "st,stm32-mfd-timer9"; > + reg = <0x40014000 0x400>; > + clocks = <&rcc 0 176>; > + clock-names = "mfd_timer_clk"; > + interrupts = <24>; > + status = "disabled"; > + > + pwm9: pwm9 at 40014000 { > + compatible = "st,stm32-pwm9"; > + status = "disabled"; > + }; > + > + iiotimer9: iiotimer9 at 40014000 { > + compatible = "st,stm32-iio-timer9"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer10: mfdtimer10 at 40014400 { > + compatible = "st,stm32-mfd-timer10"; > + reg = <0x40014400 0x400>; > + clocks = <&rcc 0 177>; > + clock-names = "mfd_timer_clk"; > + interrupts = <25>; > + status = "disabled"; > + > + pwm10: pwm10 at 40014400 { > + compatible = "st,stm32-pwm10"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer11: mfdtimer11 at 40014800 { > + compatible = "st,stm32-mfd-timer11"; > + reg = <0x40014800 0x400>; > + clocks = <&rcc 0 178>; > + clock-names = "mfd_timer_clk"; > + interrupts = <26>; > + status = "disabled"; > + > + pwm11: pwm11 at 40014800 { > + compatible = "st,stm32-pwm11"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer12: mfdtimer12 at 40001800 { > + compatible = "st,stm32-mfd-timer12"; > + reg = <0x40001800 0x400>; > + clocks = <&rcc 0 134>; > + clock-names = "mfd_timer_clk"; > + interrupts = <43>; > + status = "disabled"; > + > + pwm12: pwm12 at 40001800 { > + compatible = "st,stm32-pwm12"; > + status = "disabled"; > + }; > + iiotimer12: iiotimer12 at 40001800 { > + compatible = "st,stm32-iio-timer12"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer13: mfdtimer13 at 40001C00 { > + compatible = "st,stm32-mfd-timer13"; > + reg = <0x40001C00 0x400>; > + clocks = <&rcc 0 135>; > + clock-names = "mfd_timer_clk"; > + interrupts = <44>; > + status = "disabled"; > + > + pwm13: pwm13 at 40001C00 { > + compatible = "st,stm32-pwm13"; > + status = "disabled"; > + }; > + }; > + > + mfd_timer14: mfdtimer14 at 40002000 { > + compatible = "st,stm32-mfd-timer14"; > + reg = <0x40002000 0x400>; > + clocks = <&rcc 0 136>; > + clock-names = "mfd_timer_clk"; > + interrupts = <45>; > + status = "disabled"; > + > + pwm14: pwm14 at 40002000 { > + compatible = "st,stm32-pwm14"; > + status = "disabled"; > + }; > + }; > }; > }; > > diff --git a/arch/arm/boot/dts/stm32f469-disco.dts b/arch/arm/boot/dts/stm32f469-disco.dts > index 8a163d7..a8f1788 100644 > --- a/arch/arm/boot/dts/stm32f469-disco.dts > +++ b/arch/arm/boot/dts/stm32f469-disco.dts > @@ -81,3 +81,32 @@ > &usart3 { > status = "okay"; > }; > + > +&mfd_timer1 { > + status = "okay"; > +}; > + > +&pwm1 { > + pinctrl-0 = <&pwm1_pins>; > + pinctrl-names = "default"; > + st,breakinput-polarity = <0>; Is this documented? I'm sure we have generic polarity properties somewhere already? > + status = "okay"; > +}; > + > +&iiotimer1 { > + status = "okay"; > +}; > + > +&mfd_timer3 { > + status = "okay"; > +}; > + > +&pwm3 { > + pinctrl-0 = <&pwm3_pins>; > + pinctrl-names = "default"; > + status = "okay"; > +}; > + > +&iiotimer3 { > + status = "okay"; > +}; I've always disliked this way of referencing nodes! Any chance we can represent them in a hierarchy, so we don't lose that information and we can get rid of all those horrible labels? I'm happy to do the work. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog