From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH kvm-unit-tests v5 13/14] pci: add msi support for
 32/64bit address
Date: Wed, 23 Nov 2016 18:39:55 +0800
Message-ID: <20161123103955.GF22706@pxdev.xzpeter.org>
References: <1479248709-10281-1-git-send-email-peterx@redhat.com>
 <1479248709-10281-14-git-send-email-peterx@redhat.com>
 <20161121192751.GE30468@agordeev.lab.eng.brq.redhat.com>
 <20161122045920.GA425@pxdev.xzpeter.org>
 <20161122070306.GA6720@agordeev.lab.eng.brq.redhat.com>
 <20161122072137.GA4173@pxdev.xzpeter.org>
 <20161122123041.ppxrc3dnwdlo4fdp@kamzik.brq.redhat.com>
 <20161123024010.GB22706@pxdev.xzpeter.org>
 <20161123103617.4xhy6rmwk7oxwzyb@kamzik.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: Alexander Gordeev <agordeev@redhat.com>, kvm@vger.kernel.org,
        jan.kiszka@web.de, rkrcmar@redhat.com, pbonzini@redhat.com
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:41132 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S935117AbcKWKki (ORCPT <rfc822;kvm@vger.kernel.org>);
        Wed, 23 Nov 2016 05:40:38 -0500
Content-Disposition: inline
In-Reply-To: <20161123103617.4xhy6rmwk7oxwzyb@kamzik.brq.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Nov 23, 2016 at 11:36:17AM +0100, Andrew Jones wrote:

[...]

> > 
> > IMHO we don't need to check cap_id since cap_id is only used in:
> > 
> >   if (cap_handlers[cap_id])
> >     cap_handlers[cap_id](dev, cap_offset);
> > 
> > As long as we provide correct handlers, we'll naturally skip all
> > unknown cap_ids.
> 
> But cap_handlers only has PCI_CAP_ID_MAX + 1 (21) elements. If you
> read anything greater than 20 for cap_id, then boom.

Hmm, yes, will do. Thanks,

-- peterx