From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9VPd-0005kG-WF for qemu-devel@nongnu.org; Wed, 23 Nov 2016 06:08:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9VPd-0007YY-AG for qemu-devel@nongnu.org; Wed, 23 Nov 2016 06:08:25 -0500 Date: Wed, 23 Nov 2016 11:49:50 +0100 From: Olaf Hering Message-ID: <20161123104950.GC19126@aepfle.de> References: <20161118102452.5779-1-olaf@aepfle.de> <20161118103003.GD5717@aepfle.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lCAWRPmW1mITcIfM" Content-Disposition: inline In-Reply-To: <20161118103003.GD5717@aepfle.de> Subject: Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini , Anthony Perard , Kevin Wolf , Max Reitz Cc: qemu-block@nongnu.org, "open list:X86" , "open list:All patches CC here" --lCAWRPmW1mITcIfM Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Ping. On Fri, Nov 18, Olaf Hering wrote: > On Fri, Nov 18, Olaf Hering wrote: >=20 > > @@ -708,12 +743,10 @@ static int ioreq_runio_qemu_aio(struct ioreq *ior= eq) > > + if (!blk_split_discard(ioreq, req->sector_number, req->nr_sect= ors)) { > > + goto err; >=20 > How is error handling supposed to work here? > Initially I forgot the "!", which just hung the mkfs command in domU. > I have not yet tried to force errors in other part of that function. Olaf --lCAWRPmW1mITcIfM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAlg1dEoACgkQXUKg+qaYNn4E4gCeJUR6R5U+AEq8qICTvAJ+w85l mMYAoKrNUwrvlWLANN3AWt6wQp46FN8B =oGhE -----END PGP SIGNATURE----- --lCAWRPmW1mITcIfM-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] xen_disk: convert discard input to byte ranges Date: Wed, 23 Nov 2016 11:49:50 +0100 Message-ID: <20161123104950.GC19126@aepfle.de> References: <20161118102452.5779-1-olaf@aepfle.de> <20161118103003.GD5717@aepfle.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5805138594816533284==" Return-path: In-Reply-To: <20161118103003.GD5717@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Stefano Stabellini , Anthony Perard , Kevin Wolf , Max Reitz Cc: "open list:X86" , "open list:All patches CC here" , qemu-block@nongnu.org List-Id: xen-devel@lists.xenproject.org --===============5805138594816533284== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lCAWRPmW1mITcIfM" Content-Disposition: inline --lCAWRPmW1mITcIfM Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Ping. On Fri, Nov 18, Olaf Hering wrote: > On Fri, Nov 18, Olaf Hering wrote: >=20 > > @@ -708,12 +743,10 @@ static int ioreq_runio_qemu_aio(struct ioreq *ior= eq) > > + if (!blk_split_discard(ioreq, req->sector_number, req->nr_sect= ors)) { > > + goto err; >=20 > How is error handling supposed to work here? > Initially I forgot the "!", which just hung the mkfs command in domU. > I have not yet tried to force errors in other part of that function. Olaf --lCAWRPmW1mITcIfM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAlg1dEoACgkQXUKg+qaYNn4E4gCeJUR6R5U+AEq8qICTvAJ+w85l mMYAoKrNUwrvlWLANN3AWt6wQp46FN8B =oGhE -----END PGP SIGNATURE----- --lCAWRPmW1mITcIfM-- --===============5805138594816533284== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5805138594816533284==--