From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097 Date: Wed, 23 Nov 2016 18:40:40 +0100 Message-ID: <20161123174040.GE8760@lunn.ch> References: <20161123165022.GD12698@gruene.netmodule.intranet> <20161123165440.4894-1-stefan.eichenberger@netmodule.com> <20161123165949.GB8760@lunn.ch> <20161123171441.GE12698@gruene.netmodule.intranet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Stefan Eichenberger , vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org To: Stefan Eichenberger Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:50123 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933957AbcKWRlg (ORCPT ); Wed, 23 Nov 2016 12:41:36 -0500 Content-Disposition: inline In-Reply-To: <20161123171441.GE12698@gruene.netmodule.intranet> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Nov 23, 2016 at 06:14:41PM +0100, Stefan Eichenberger wrote: > On Wed, Nov 23, 2016 at 05:59:49PM +0100, Andrew Lunn wrote: > > On Wed, Nov 23, 2016 at 05:54:40PM +0100, Stefan Eichenberger wrote: > > > Packets with unknown destination addresses are not forwarded to the cpu > > > port on mv88e6097 based switches (e.g. MV88E6097) at the moment. This > > > commit enables PORT_CONTROL_FORWARD_UNKNOWN_MC for this family. > > > > Please try adding MV88E6XXX_FLAG_EDSA to > > MV88E6XXX_FLAGS_FAMILY_6097. That is the better fix if it works. > > I was even wondering what EDSA means:) Thanks this solved the problem! Plain DSA puts four bytes of header between the MAC source address and the EtherType/Length. EDSA puts in an 8 byte header, and includes an Ethertype value of 0xdada. Having that ethertype value makes it more obvious what is going on. And if you have a recent version of tcpdump, it will decode the header. Andrew