All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, samuel.thibault@ens-lyon.org
Cc: quintela@redhat.com, amit.shah@redhat.com
Subject: [Qemu-devel] [PATCH v2 3/5] slirp: Common lhost/fhost union
Date: Wed, 23 Nov 2016 18:52:56 +0000	[thread overview]
Message-ID: <20161123185258.771-4-dgilbert@redhat.com> (raw)
In-Reply-To: <20161123185258.771-1-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

The socket structure has a pair of unions for lhost and fhost
addresses; the unions are identical so split them out into
a separate union declaration.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 slirp/socket.h | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/slirp/socket.h b/slirp/socket.h
index 8feed2a..c1be77e 100644
--- a/slirp/socket.h
+++ b/slirp/socket.h
@@ -15,6 +15,12 @@
  * Our socket structure
  */
 
+union slirp_sockaddr {
+    struct sockaddr_storage ss;
+    struct sockaddr_in sin;
+    struct sockaddr_in6 sin6;
+};
+
 struct socket {
   struct socket *so_next,*so_prev;      /* For a linked list of sockets */
 
@@ -31,22 +37,14 @@ struct socket {
   struct tcpiphdr *so_ti;	   /* Pointer to the original ti within
 				    * so_mconn, for non-blocking connections */
   int so_urgc;
-  union {   /* foreign host */
-      struct sockaddr_storage ss;
-      struct sockaddr_in sin;
-      struct sockaddr_in6 sin6;
-  } fhost;
+  union slirp_sockaddr fhost;      /* Foreign host */
 #define so_faddr fhost.sin.sin_addr
 #define so_fport fhost.sin.sin_port
 #define so_faddr6 fhost.sin6.sin6_addr
 #define so_fport6 fhost.sin6.sin6_port
 #define so_ffamily fhost.ss.ss_family
 
-  union {   /* local host */
-      struct sockaddr_storage ss;
-      struct sockaddr_in sin;
-      struct sockaddr_in6 sin6;
-  } lhost;
+  union slirp_sockaddr lhost;      /* Local host */
 #define so_laddr lhost.sin.sin_addr
 #define so_lport lhost.sin.sin_port
 #define so_laddr6 lhost.sin6.sin6_addr
-- 
2.9.3

  parent reply	other threads:[~2016-11-23 18:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23 18:52 [Qemu-devel] [PATCH v2 0/5] SLIRP VMStatification [ for 2.9 ] Dr. David Alan Gilbert (git)
2016-11-23 18:52 ` [Qemu-devel] [PATCH v2 1/5] slirp: VMState conversion; tcpcb Dr. David Alan Gilbert (git)
2016-11-23 18:52 ` [Qemu-devel] [PATCH v2 2/5] slirp: VMStatify sbuf Dr. David Alan Gilbert (git)
2016-11-23 18:52 ` Dr. David Alan Gilbert (git) [this message]
2016-11-23 18:52 ` [Qemu-devel] [PATCH v2 4/5] slirp: VMStatify socket level Dr. David Alan Gilbert (git)
2016-11-27 15:13   ` Samuel Thibault
2016-11-27 15:28     ` Samuel Thibault
2016-11-28  9:08       ` Dr. David Alan Gilbert
2016-11-28 10:48         ` Samuel Thibault
2016-11-30 11:54           ` Dr. David Alan Gilbert
2016-11-23 18:52 ` [Qemu-devel] [PATCH v2 5/5] slirp: VMStatify remaining except for loop Dr. David Alan Gilbert (git)
2016-11-29  8:31 ` [Qemu-devel] [PATCH v2 0/5] SLIRP VMStatification [ for 2.9 ] no-reply
2016-11-29 13:33 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161123185258.771-4-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.