All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: fix ignored trace at target-finalize
Date: Wed, 23 Nov 2016 23:22:09 +0100	[thread overview]
Message-ID: <20161123232209.52e93240@free-electrons.com> (raw)
In-Reply-To: <20161122205333.9735-1-gael.portay@savoirfairelinux.com>

Hello,

On Tue, 22 Nov 2016 15:53:33 -0500, Ga?l PORTAY wrote:
> Make may throw an error (but ignored) trace when cleaning up the
> rootfs.
> 
> The target-finalize rule intends to remove the folder
> `$(TARGET_DIR)/usr/share' but this directory may still contain items
> (such as the `udhcpc' helper script) and causes the rmdir to fail.
> 
> The stderr output is redirected to /dev/null but it returns and error
> which is escaped by the leading `-'; but make reports an ignored-error.
> 
> See the log below:
> $ make
> (...)
> rm -rf (...)/target/usr/share/gtk-doc
> rmdir (...)/target/usr/share
> rmdir: failed to remove '(...)/target/usr/share': Directory not empty
> make[1]: [Makefile:650: target-finalize] Error 1 (ignored)
> find /(...)/target -type f \( -perm /111 -o -name '*.so*' \) -not \( -name 'libpthread*.so*' -o -name 'ld-*.so*' -o -name '*.ko' \) -print0 | xargs -0 (...)/host/usr/bin/arm-buildroot-linux-uclibcgnueabihf-strip --remove-section=.comment --remove-section=.note 2>/dev/null || true
> 
> This patch apply the same rule at the instruction immediately after:
> * redirecting stderr to /dev/null (already done) and
> * executing true if the `rmdir' instruction fails.
> 
> Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to next, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2016-11-23 22:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22 20:53 [Buildroot] [PATCH] Makefile: fix ignored trace at target-finalize Gaël PORTAY
2016-11-22 21:33 ` Yann E. MORIN
2016-11-23  8:24 ` Thomas Petazzoni
2016-11-23 14:30   ` Gaël PORTAY
2016-11-23 22:22 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161123232209.52e93240@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.