From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: wexu@redhat.com, qemu-devel@nongnu.org, dfleytma@redhat.com,
yvugenfi@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic
Date: Thu, 24 Nov 2016 06:26:51 +0200 [thread overview]
Message-ID: <20161124062419-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <69ada11c-c401-b85a-66bc-78d3a0b82e2c@redhat.com>
On Thu, Nov 24, 2016 at 12:17:21PM +0800, Jason Wang wrote:
> > diff --git a/include/standard-headers/linux/virtio_net.h b/include/standard-headers/linux/virtio_net.h
> > index 30ff249..e67b36e 100644
> > --- a/include/standard-headers/linux/virtio_net.h
> > +++ b/include/standard-headers/linux/virtio_net.h
> > @@ -57,6 +57,9 @@
> > * Steering */
> > #define VIRTIO_NET_F_CTRL_MAC_ADDR 23 /* Set MAC address */
> > +/* Guest can handle coalesced ipv4-tcp packets */
> > +#define VIRTIO_NET_F_GUEST_RSC4 41
>
> Why not use 24?
I think we should use features >31 (virtio 1 only) for
nice-to-have features like RSC. Feature bits <31 are
easy to backport, so it makes more sense to use
them for fundamental things like the MTU
(which for some setups help fix broken networking).
next prev parent reply other threads:[~2016-11-24 4:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 17:41 [Qemu-devel] [ RFC Patch v7 0/2] Support Receive-Segment-Offload(RSC) for WHQL wexu
2016-10-31 17:41 ` [Qemu-devel] [PATCH 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic wexu
2016-11-24 4:17 ` Jason Wang
2016-11-24 4:26 ` Michael S. Tsirkin [this message]
2016-11-24 4:31 ` Jason Wang
2016-11-24 5:09 ` Michael S. Tsirkin
2016-11-30 8:55 ` Wei Xu
2016-11-30 11:12 ` Jason Wang
2016-10-31 17:41 ` [Qemu-devel] [PATCH 2/2] virtio-net rsc: support coalescing ipv6 " wexu
2016-11-24 4:28 ` [Qemu-devel] [ RFC Patch v7 0/2] Support Receive-Segment-Offload(RSC) for WHQL Jason Wang
2016-11-25 1:37 ` Wei Xu
-- strict thread matches above, loose matches on Subject: below --
2016-03-15 9:17 [Qemu-devel] [ Patch 0/2] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest wexu
2016-03-15 9:17 ` [Qemu-devel] [ Patch 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic wexu
2016-03-15 10:00 ` Michael S. Tsirkin
2016-03-16 3:23 ` Wei Xu
2016-03-17 8:42 ` Jason Wang
2016-03-17 16:45 ` Wei Xu
2016-03-18 2:03 ` Jason Wang
2016-03-18 4:17 ` Wei Xu
2016-03-18 5:20 ` Jason Wang
2016-03-18 6:38 ` Wei Xu
2016-03-18 6:56 ` Jason Wang
2016-03-18 14:52 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124062419-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dfleytma@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wexu@redhat.com \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.