From: Simon Horman <horms@verge.net.au>
To: Geoff Levand <geoff@infradead.org>
Cc: Pratyush Anand <panand@redhat.com>, kexec@lists.infradead.org
Subject: Re: [PATCH] purgatory: Change default sha256 optimization to -O2
Date: Thu, 24 Nov 2016 08:53:55 +0100 [thread overview]
Message-ID: <20161124075355.GC13096@verge.net.au> (raw)
In-Reply-To: <32a52ca4-8741-e0e6-92c1-6b9583fa479b@infradead.org>
On Wed, Nov 23, 2016 at 09:57:09AM -0800, Geoff Levand wrote:
> Change the default purgatory sha256 code optimization from -O0 to -O2, and add a
> new arch specific makefile variable $(ARCH)_PURGATORY_SHA256_CFLAGS which can
> over ride this default. Set ia64_PURGATORY_SHA256_CFLAGS to -O0 to retain the
> previous optimization level for ia64.
>
> The purgatory sha256 code needs the be built with -O0 for the ia64
> architecture. Currently this code is built with -O0 for all architectures,
> which slows down the calculations for architectures which could otherwise
> use -O2.
Could you give an indication of the performance improvement you expect,
e.g. on arm64?
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
> purgatory/Makefile | 4 +---
> purgatory/arch/ia64/Makefile | 4 ++++
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/purgatory/Makefile b/purgatory/Makefile
> index ca0443c..328904e 100644
> --- a/purgatory/Makefile
> +++ b/purgatory/Makefile
> @@ -38,9 +38,7 @@ clean += $(PURGATORY_OBJS) $(PURGATORY_DEPS) $(PURGATORY)
> -include $(PURGATORY_DEPS)
> -# sha256.c needs to be compiled without optimization, else
> -# purgatory fails to execute on ia64.
> -purgatory/sha256.o: CFLAGS += -O0
> +purgatory/sha256.o: CFLAGS += -O2 $($(ARCH)_PURGATORY_SHA256_CFLAGS)
> purgatory/sha256.o: $(srcdir)/util_lib/sha256.c
> mkdir -p $(@D)
> diff --git a/purgatory/arch/ia64/Makefile b/purgatory/arch/ia64/Makefile
> index 32c3d97..4a2564c 100644
> --- a/purgatory/arch/ia64/Makefile
> +++ b/purgatory/arch/ia64/Makefile
> @@ -8,6 +8,10 @@ ia64_PURGATORY_SRCS += purgatory/arch/ia64/vga.c
> ia64_PURGATORY_EXTRA_CFLAGS = -ffixed-r28
> +# sha256.c needs to be compiled without optimization, else
> +# purgatory fails to execute on ia64.
> +ia64_PURGATORY_SHA256_CFLAGS = -O0
> +
> dist += purgatory/arch/ia64/Makefile $(ia64_PURGATORY_SRCS) \
> purgatory/arch/ia64/io.h purgatory/arch/ia64/purgatory-ia64.h
> --
> 2.7.4
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-11-24 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 17:57 [PATCH] purgatory: Change default sha256 optimization to -O2 Geoff Levand
2016-11-24 7:53 ` Simon Horman [this message]
2016-11-28 5:44 ` Pratyush Anand
2016-11-30 11:02 ` Simon Horman
2016-12-01 19:09 ` Geoff Levand
2016-12-01 19:09 ` [PATCH V2] " Geoff Levand
2016-12-02 8:21 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2015-11-06 20:36 [PATCH] " Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124075355.GC13096@verge.net.au \
--to=horms@verge.net.au \
--cc=geoff@infradead.org \
--cc=kexec@lists.infradead.org \
--cc=panand@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.