From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 24 Nov 2016 11:35:45 +0000 Subject: [patch] drm/hisilicon/hibmc: Checking for NULL instead of IS_ERR() Message-Id: <20161124113545.GP17225@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Xinliang Liu , Rongrong Zou Cc: Chen Feng , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org The drm_dev_alloc() function returns error pointers. It never returns NULLs. Fixes: 5e0df3a08f3d ("drm/hisilicon/hibmc: Add hisilicon hibmc drm master driver") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c index 73ba8b0..d94e349 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c @@ -377,9 +377,9 @@ static int hibmc_pci_probe(struct pci_dev *pdev, int ret; dev = drm_dev_alloc(&hibmc_driver, &pdev->dev); - if (!dev) { + if (IS_ERR(dev)) { DRM_ERROR("failed to allocate drm_device\n"); - return -ENOMEM; + return PTR_ERR(dev); } dev->pdev = pdev; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] drm/hisilicon/hibmc: Checking for NULL instead of IS_ERR() Date: Thu, 24 Nov 2016 14:35:45 +0300 Message-ID: <20161124113545.GP17225@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id B4AEF6E980 for ; Thu, 24 Nov 2016 11:36:11 +0000 (UTC) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Xinliang Liu , Rongrong Zou Cc: Chen Feng , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org VGhlIGRybV9kZXZfYWxsb2MoKSBmdW5jdGlvbiByZXR1cm5zIGVycm9yIHBvaW50ZXJzLiAgSXQg bmV2ZXIgcmV0dXJucwpOVUxMcy4KCkZpeGVzOiA1ZTBkZjNhMDhmM2QgKCJkcm0vaGlzaWxpY29u L2hpYm1jOiBBZGQgaGlzaWxpY29uIGhpYm1jIGRybSBtYXN0ZXIgZHJpdmVyIikKU2lnbmVkLW9m Zi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgoKZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24vaGlibWMvaGlibWNfZHJtX2Rydi5jIGIvZHJp dmVycy9ncHUvZHJtL2hpc2lsaWNvbi9oaWJtYy9oaWJtY19kcm1fZHJ2LmMKaW5kZXggNzNiYThi MC4uZDk0ZTM0OSAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9oaWJtYy9o aWJtY19kcm1fZHJ2LmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9oaWJtYy9oaWJt Y19kcm1fZHJ2LmMKQEAgLTM3Nyw5ICszNzcsOSBAQCBzdGF0aWMgaW50IGhpYm1jX3BjaV9wcm9i ZShzdHJ1Y3QgcGNpX2RldiAqcGRldiwKIAlpbnQgcmV0OwogCiAJZGV2ID0gZHJtX2Rldl9hbGxv YygmaGlibWNfZHJpdmVyLCAmcGRldi0+ZGV2KTsKLQlpZiAoIWRldikgeworCWlmIChJU19FUlIo ZGV2KSkgewogCQlEUk1fRVJST1IoImZhaWxlZCB0byBhbGxvY2F0ZSBkcm1fZGV2aWNlXG4iKTsK LQkJcmV0dXJuIC1FTk9NRU07CisJCXJldHVybiBQVFJfRVJSKGRldik7CiAJfQogCiAJZGV2LT5w ZGV2ID0gcGRldjsKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg==