From: "Allan W. Nielsen" <allan.nielsen@microsemi.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<bcm-kernel-feedback-list@broadcom.com>, <andrew@lunn.ch>,
<raju.lakkaraju@microsemi.com>,
<vivien.didelot@savoirfairelinux.com>
Subject: Re: [PATCH net-next v2] ethtool: Protect {get,set}_phy_tunable with PHY device mutex
Date: Thu, 24 Nov 2016 12:48:10 +0100 [thread overview]
Message-ID: <20161124114809.GG4457@microsemi.com> (raw)
In-Reply-To: <20161122215531.18212-1-f.fainelli@gmail.com>
On 22/11/16 13:55, Florian Fainelli wrote:
> EXTERNAL EMAIL
>
>
> PHY drivers should be able to rely on the caller of {get,set}_tunable to
> have acquired the PHY device mutex, in order to both serialize against
> concurrent calls of these functions, but also against PHY state machine
> changes. All ethtool PHY-level functions do this, except
> {get,set}_tunable, so we make them consistent here as well.
>
> We need to update the Microsemi PHY driver in the same commit to avoid
> introducing either deadlocks, or lack of proper locking.
>
> Fixes: 968ad9da7e0e ("ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE")
> Fixes: 310d9ad57ae0 ("net: phy: Add downshift get/set support in Microsemi PHYs driver")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Allan W. Nielsen <allan.nielsen@microsemi.com>
next prev parent reply other threads:[~2016-11-24 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 21:55 [PATCH net-next v2] ethtool: Protect {get,set}_phy_tunable with PHY device mutex Florian Fainelli
2016-11-23 22:43 ` Andrew Lunn
2016-11-24 11:48 ` Allan W. Nielsen [this message]
2016-11-24 21:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124114809.GG4457@microsemi.com \
--to=allan.nielsen@microsemi.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=raju.lakkaraju@microsemi.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.