From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH nf 0/2] netfilter: nat: fix regressions introduced by rhashtable conversion
Date: Thu, 24 Nov 2016 13:53:12 +0100 [thread overview]
Message-ID: <20161124125312.GA23970@salvia> (raw)
In-Reply-To: <1479305616-4171-1-git-send-email-fw@strlen.de>
On Wed, Nov 16, 2016 at 03:13:34PM +0100, Florian Westphal wrote:
> These two patches address bugs added when I converted the nat bysource hash
> to rhashtable.
>
> First patch fixes object comparision, second patch converts
> nat bysource to the rhlist interface, we have to deal with identical
> source identities (distinct connections sharing same ip/port source pair).
>
> Unfortunately the rhashlist interface isn't available in 4.8, so the question
> is how to address patch #2 for -stable.
>
> One way would be to revert the rhashtable conversion, the other one
> would be to just set .insecure_elasticity in the rhashtable params.
>
> The latter should work fine, as we do NOT need to identify the individual
> duplicate keys.
Series applied, thanks Florian.
prev parent reply other threads:[~2016-11-24 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 14:13 [PATCH nf 0/2] netfilter: nat: fix regressions introduced by rhashtable conversion Florian Westphal
2016-11-16 14:13 ` [PATCH nf 1/2] netfilter: nat: fix cmp return value Florian Westphal
2016-11-16 14:13 ` [PATCH nf 2/2] netfilter: nat: switch to new rhlist interface Florian Westphal
2016-11-24 12:53 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124125312.GA23970@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=herbert@gondor.apana.org.au \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.