All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Laura Garcia Liebana <nevola@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: nf_tables: validate maximum value of u32 netlink hash attribute
Date: Thu, 24 Nov 2016 14:43:17 +0100	[thread overview]
Message-ID: <20161124134317.GA32280@salvia> (raw)
In-Reply-To: <20161114213331.GA13743@sonyv>

On Mon, Nov 14, 2016 at 10:33:34PM +0100, Laura Garcia Liebana wrote:
> Use the function nft_parse_u32_check() to fetch the value and validate
> the u32 attribute into the hash len u8 field.
> 
> This patch revisits 4da449ae1df9 ("netfilter: nft_exthdr: Add size check
> on u8 nft_exthdr attributes").

Applied, thanks.

Please, always target your fixes to nf.

New features go to nf-next.

Regarding patch title, in second place we usually specify to what
component this is targeted to, so I would suggest:

  netfilter: nft_hash: validate maximum value of u32 netlink hash attribute

so git log --oneline quickly tells us this is targetd to nft_hash.

I have also added this tag which is useful for -stable maintainers:

Fixes: cb1b69b0b15b ("netfilter: nf_tables: add hash expression")

Thanks Laura!

      reply	other threads:[~2016-11-24 13:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 21:33 [PATCH nf-next] netfilter: nf_tables: validate maximum value of u32 netlink hash attribute Laura Garcia Liebana
2016-11-24 13:43 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161124134317.GA32280@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=nevola@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.