From: Jiri Olsa <jolsa@redhat.com>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"acme@kernel.org" <acme@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"wangnan0@huawei.com" <wangnan0@huawei.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"andi@firstfloor.org" <andi@firstfloor.org>
Subject: Re: [PATCH 01/14] perf/x86: Introduce PERF_RECORD_OVERHEAD
Date: Thu, 24 Nov 2016 15:47:47 +0100 [thread overview]
Message-ID: <20161124144747.GB30490@krava> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F07750CA2C2F@SHSMSX103.ccr.corp.intel.com>
On Thu, Nov 24, 2016 at 02:39:26PM +0000, Liang, Kan wrote:
>
>
> > On Thu, Nov 24, 2016 at 01:56:51PM +0000, Liang, Kan wrote:
> > >
> > >
> > > >
> > > > On Thu, Nov 24, 2016 at 01:45:28PM +0000, Liang, Kan wrote:
> > > > > > I think we should make this optional/configurable like the rest
> > > > > > of the aux events, like below..
> > > > > >
> > > > >
> > > > > The overhead logging only happens when event is going to be
> > > > > disabled or the task is scheduling out. It should not be much and
> > expensive.
> > > > >
> > > > > Peter,
> > > > >
> > > > > What do you think?
> > > > > Should we make it configurable?
> > > >
> > > > Is there a downside to having it optional?
> > >
> > > NO. There will be no overhead information dumped into perf.data. Just
> > > like current implementation.
> >
> > old perf tools will get unexpected events if it's not optional
> >
>
> That's expected because a new record type is introduced.
but not if it's configurable.. older tools wont get it
jirka
next prev parent reply other threads:[~2016-11-24 14:47 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 9:44 [PATCH 00/14] export perf overheads information kan.liang
2016-11-23 9:44 ` [PATCH 01/14] perf/x86: Introduce PERF_RECORD_OVERHEAD kan.liang
2016-11-23 20:11 ` Peter Zijlstra
2016-11-23 20:13 ` Peter Zijlstra
2016-11-23 23:41 ` Jiri Olsa
2016-11-24 13:45 ` Liang, Kan
2016-11-24 13:50 ` Peter Zijlstra
2016-11-24 13:56 ` Liang, Kan
2016-11-24 14:27 ` Jiri Olsa
2016-11-24 14:39 ` Liang, Kan
2016-11-24 14:47 ` Jiri Olsa [this message]
2016-11-24 18:28 ` Andi Kleen
2016-11-24 18:58 ` Peter Zijlstra
2016-11-24 19:02 ` Andi Kleen
2016-11-24 19:08 ` Peter Zijlstra
2016-11-23 9:44 ` [PATCH 02/14] perf/x86: output NMI overhead kan.liang
2016-11-23 20:06 ` Peter Zijlstra
2016-11-24 16:19 ` Mark Rutland
2016-11-24 19:02 ` Peter Zijlstra
2016-11-24 19:40 ` Liang, Kan
2016-11-24 23:26 ` Namhyung Kim
2016-11-23 9:44 ` [PATCH 03/14] perf/x86: output multiplexing overhead kan.liang
2016-11-23 20:06 ` Peter Zijlstra
2016-11-23 20:09 ` Liang, Kan
2016-11-23 9:44 ` [PATCH 04/14] perf/x86: output side-band events overhead kan.liang
2016-11-23 20:06 ` Peter Zijlstra
2016-11-24 16:21 ` Mark Rutland
2016-11-24 19:40 ` Liang, Kan
2016-11-23 9:44 ` [PATCH 05/14] perf tools: handle PERF_RECORD_OVERHEAD record type kan.liang
2016-11-23 22:35 ` Jiri Olsa
2016-11-23 22:58 ` Jiri Olsa
2016-11-23 9:44 ` [PATCH 06/14] perf tools: show NMI overhead kan.liang
2016-11-23 22:51 ` Jiri Olsa
2016-11-24 13:37 ` Liang, Kan
2016-11-24 15:27 ` Jiri Olsa
2016-11-24 23:20 ` Namhyung Kim
2016-11-24 23:45 ` Jiri Olsa
2016-11-25 0:21 ` Andi Kleen
2016-11-23 22:52 ` Jiri Olsa
2016-11-23 22:52 ` Jiri Olsa
2016-11-23 9:44 ` [PATCH 07/14] perf tools: show multiplexing overhead kan.liang
2016-11-23 9:44 ` [PATCH 08/14] perf tools: show side-band events overhead kan.liang
2016-11-23 9:44 ` [PATCH 09/14] perf tools: make get_nsecs visible for buildin files kan.liang
2016-11-23 9:44 ` [PATCH 10/14] perf tools: introduce PERF_RECORD_USER_OVERHEAD kan.liang
2016-11-23 9:44 ` [PATCH 11/14] perf tools: record write data overhead kan.liang
2016-11-23 23:02 ` Jiri Olsa
2016-11-23 23:06 ` Jiri Olsa
2016-11-23 9:44 ` [PATCH 12/14] perf tools: record elapsed time kan.liang
2016-11-23 9:44 ` [PATCH 13/14] perf tools: warn on high overhead kan.liang
2016-11-23 20:25 ` Andi Kleen
2016-11-23 22:03 ` Liang, Kan
2016-11-25 20:42 ` Andi Kleen
2016-11-23 9:44 ` [PATCH 14/14] perf script: show overhead events kan.liang
2016-11-23 23:17 ` Jiri Olsa
2016-11-23 23:18 ` Jiri Olsa
2016-11-23 23:19 ` Jiri Olsa
2016-11-23 23:22 ` Jiri Olsa
2016-11-24 4:27 ` [PATCH 00/14] export perf overheads information Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124144747.GB30490@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.