From: Andrew Lunn <andrew@lunn.ch>
To: Yegor Yefremov <yegorslists@googlemail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev <netdev@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
"N, Mugunthan V" <mugunthanvnm@ti.com>,
Rami Rosen <roszenrami@gmail.com>
Subject: Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers
Date: Thu, 24 Nov 2016 16:38:09 +0100 [thread overview]
Message-ID: <20161124153809.GA20455@lunn.ch> (raw)
In-Reply-To: <CAGm1_ktuAbt0pr_NJu2GLDOavFV_bvMBmH5RvDxr5AyXvfwB3A@mail.gmail.com>
> As for enabling advertising and correct working of cpsw do you mean it
> would be better to disable EEE in any PHY on cpsw initialization as
> long as cpsw doesn't provide support for EEE?
>
> We observe some strange behavior with our gigabit PHYs and a link
> partner in a EEE-capable unmanaged NetGear switch. Disabling
> advertising seems to help. Though we're still investigating the issue.
Hi Florian
Am i right in saying, a PHY should not advertise EEE until the MAC
driver calls phy_init_eee(), indicating the MAC supports EEE?
If so, it looks like we need to change a few of the PHY drivers, in
particular, the bcm-*.c.
Andrew
next prev parent reply other threads:[~2016-11-24 15:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 14:38 [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers yegorslists
2016-11-23 14:47 ` Rami Rosen
2016-11-23 17:33 ` Florian Fainelli
2016-11-23 20:08 ` Yegor Yefremov
2016-11-23 20:15 ` Florian Fainelli
2016-11-24 9:25 ` Yegor Yefremov
2016-11-24 15:38 ` Andrew Lunn [this message]
2016-11-24 18:23 ` Florian Fainelli
2016-12-02 9:11 ` Giuseppe CAVALLARO
2016-12-02 17:48 ` Florian Fainelli
2017-01-04 14:33 ` Florian Fainelli
2017-04-18 13:23 ` Niklas Cassel
2017-04-18 16:40 ` Florian Fainelli
2017-04-25 9:06 ` Niklas Cassel
2017-04-25 9:06 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124153809.GA20455@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=roszenrami@gmail.com \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.