From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] sparc64: enable IRQs on error paths
Date: Fri, 25 Nov 2016 13:46:42 +0000 [thread overview]
Message-ID: <20161125133524.GA28558@mwanda> (raw)
In-Reply-To: <20161125111054.GE5938@mwanda>
On Fri, Nov 25, 2016 at 08:11:44AM -0500, Sowmini Varadhan wrote:
> On (11/25/16 16:01), Dan Carpenter wrote:
> > I'm pretty sure the Fixes tag is correct. Originally it did:
> >
> > +iommu_map_fail:
> > + /* Interrupts are disabled. */
> > + spin_lock(&iommu->lock);
> > + pci_arena_free(&iommu->arena, entry, npages);
> > + spin_unlock_irqrestore(&iommu->lock, flags);
> > +
>
> In that case why dont you just do the local_irq_restore
> once at the iommu_map_fail label?
I thought this way was easier to read. It doesn't really matter?
regards,
dan carpenter
next prev parent reply other threads:[~2016-11-25 13:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 11:12 [patch] sparc64: enable IRQs on error paths Dan Carpenter
2016-11-25 12:32 ` Sowmini Varadhan
2016-11-25 13:01 ` Dan Carpenter
2016-11-25 13:11 ` Sowmini Varadhan
2016-11-25 13:46 ` Dan Carpenter [this message]
2016-11-25 13:57 ` Sowmini Varadhan
2016-11-25 20:45 ` Sam Ravnborg
2016-11-25 21:06 ` tndave
2016-11-25 21:11 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161125133524.GA28558@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.