Re: [Qemu-devel] [PATCH] cutils: Define min and max marcos

[Yuval Shaia <yuval.shaia@oracle.com>]

On Sun, Nov 27, 2016 at 03:10:04PM +0100, Samuel Thibault wrote:
> Hello,
> 
> Yuval Shaia, on Fri 25 Nov 2016 12:31:26 +0200, wrote:
> > -#ifndef _WIN32
> > -#define min(x,y) ((x) < (y) ? (x) : (y))
> > -#define max(x,y) ((x) > (y) ? (x) : (y))
> > -#endif
> 
> This has protection against _WIN32, I guess that was on purpose.

I'm not following.
Are you suggesting that this was there to prevent code from compiling when
_WIN32 was define?

> Perhaps qemu should avoid risking a clash with OS-provided min/max
> macros, by renaming these to qemu_min/max?

On MIN and MAX?

I have noticed some other approach which was taken in osdep.h with ifdef,
for example:
193 #ifndef ROUND_UP
194 #define ROUND_UP(n,d) (((n) + (d) - 1) & -(d))
195 #endif

> 
> Samuel