From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 01/11] drm/vgem: Use ww_mutex_(un)lock even with a NULL context Date: Mon, 28 Nov 2016 13:50:24 +0100 Message-ID: <20161128125024.GZ3092@twins.programming.kicks-ass.net> References: <1480335612-12069-1-git-send-email-nhaehnle@gmail.com> <1480335612-12069-2-git-send-email-nhaehnle@gmail.com> <03202725-ecf3-1b49-f22a-1cbff84156bc@mblankhorst.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 290506E276 for ; Mon, 28 Nov 2016 12:50:31 +0000 (UTC) Content-Disposition: inline In-Reply-To: <03202725-ecf3-1b49-f22a-1cbff84156bc@mblankhorst.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: Nicolai =?iso-8859-1?Q?H=E4hnle?= , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ingo Molnar List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBOb3YgMjgsIDIwMTYgYXQgMDE6NDI6MjZQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cgo+ID4gKwl3d19tdXRleF9sb2NrKCZyZXN2LT5sb2NrLmJhc2UsIE5VTEwpOwo+ IFl1Y2ssIGNhbiB3ZSByZW5hbWUgYmFzZSB0byBfX05FVkVSX1RPVUNIX0RJUkVDVExZX09VVFNJ REVfTE9DS0lOR19DT1JFPwo+IEl0J3MgaGFyZGVyIHRvIGdldCB0aGVtIGNvbmZ1c2VkIGxpa2Ug dGhhdCwgZXZlbiB3aXRoIGEgbnVsbCBjb250ZXh0IGl0J3MgaWxsZWdhbCB0byBjYWxsIG11dGV4 X2xvY2svdW5sb2NrIGRpcmVjdGx5LgoKSSB0aGluayB0aGVyZSdzIGEgX19wcml2YXRlIHNwYXJz ZSBhbm5vdGF0aW9uIHRoYXQgY291bGQgYmUgdXNlZC4KX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754584AbcK1Mun (ORCPT ); Mon, 28 Nov 2016 07:50:43 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:48251 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754388AbcK1Muf (ORCPT ); Mon, 28 Nov 2016 07:50:35 -0500 Date: Mon, 28 Nov 2016 13:50:24 +0100 From: Peter Zijlstra To: Maarten Lankhorst Cc: Nicolai =?iso-8859-1?Q?H=E4hnle?= , linux-kernel@vger.kernel.org, Nicolai =?iso-8859-1?Q?H=E4hnle?= , Ingo Molnar , Daniel Vetter , Chris Wilson , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 01/11] drm/vgem: Use ww_mutex_(un)lock even with a NULL context Message-ID: <20161128125024.GZ3092@twins.programming.kicks-ass.net> References: <1480335612-12069-1-git-send-email-nhaehnle@gmail.com> <1480335612-12069-2-git-send-email-nhaehnle@gmail.com> <03202725-ecf3-1b49-f22a-1cbff84156bc@mblankhorst.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <03202725-ecf3-1b49-f22a-1cbff84156bc@mblankhorst.nl> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 28, 2016 at 01:42:26PM +0100, Maarten Lankhorst wrote: > > + ww_mutex_lock(&resv->lock.base, NULL); > Yuck, can we rename base to __NEVER_TOUCH_DIRECTLY_OUTSIDE_LOCKING_CORE? > It's harder to get them confused like that, even with a null context it's illegal to call mutex_lock/unlock directly. I think there's a __private sparse annotation that could be used.